-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong sample rate with record_session #1112
Comments
check the SDP . Firefox vs Chrome . The difference may be coming from Opus's fmtp. |
After some testing i was able to narrow it down to the opus codec. I check the SDP. |
When I compare the two Local SDP messages, I notice the following:
and Firefox:
|
The telephone-event is unrelated. Maybe it has something to do with Firefox setting "stereo=1" . |
Is there a way to force this as "mono"? |
try this patch #1115 . put this in opus cfg: |
the patch will enforce mono. however, I tried to reproduce what you say about the sample rate with Firefox, but I didn't get the same as you, I get a stereo file at 16 khz with the above settings in dialplan, which is expected. |
The whole snippet is this: (due to my fault with the code formatting github didn't show the first line)
I made the changes to mod_opus and got the same results: Chrome is fine and Firefox isn't. Update: On Android 11 its the same with both browsers |
please show FS debug logs (both browsers) |
freeswitch.log |
Needs fix in core media:
|
I guess you mean this file: https://github.com/signalwire/freeswitch/blob/master/src/switch_core_media.c#L5776 |
I pushed a commit that does a change in the code I've shown. You will need to add a param to autoload_configs/switch.conf.xml . |
Could you please link me the commit? I didn't find it, sorry. |
This branch with the 2 commits: #1115 |
the branch was merged. |
Describe the bug
When using record_session in my dialplan (or with mod_audio_fork its the same) and set the record_sample_rate to 16khz it works perfect with Chrome 89. When using Firefox 86 (bot x64 on Windows 10) the rate doubles to 32khz. When changing the sample rate to 8khz it works fine with Firefox.
Update: After some testing i can narrow the problem down to the opus codec. When i comment out the mod_opus module the audio data from both browser is fine.
To Reproduce
Expected behavior
A record with everytime 16khz sample rate
Package version or git hash
I use FreeSwitch in BigBlueButton 2.2.
The text was updated successfully, but these errors were encountered: