WIP [mod_python, ESL] Add Python3 support.

[mochouinard]

This is an initial commit for mod_python3 support. A few of the changes I've done here would also be good for mod_python, but decided to wait before this is accepted to back port it.

Python 2.7 is going EOF in a few days... So it about time we move to Python3.

I also have a patch to get ESL python3 to compile.

This is regarding support ticket : #186

[mochouinard]

I've added the ESL patch in there as a seperate commit as well..

[mochouinard]

I think I wasn't clear in the first message... the mod_python3 is just an initial commit... but it doesn't work... It just compile. I changed a few function name that have to be reviewed with the correct one, and commented out a few things.

the patch for ESL integration does work and I do use it just fine though.

[mneirynck]

Any idea when this might get integrated and python3 gets the default requirement?

[mochouinard]

We must first finish the module ! It is not currently functionning.

[mochouinard]

This this latest patch, I merged the changes with mod_python. It not super pretty and final yet, but you may give it a try !

[zuheo23]

Thanks for the patch. i managed to compile and run a print statement (def fsapi) from fs_cli using your mod_python patch without the changes in "configure.ac". May be I applied the patch wrongly.
wget https://github...../....191.patch
git am ....191.patch
doesn't work
so I applied manually line by line.
Will keep testing by writing more modules

[Ajinkya009]

Thank you for the patch @mochouinard. We manually entered all the changes mentioned in the patch and then built the library. But when we try to import it, we get following errors:

ImportError                               Traceback (most recent call last)
<ipython-input-2-a536c87db710> in <module>
----> 1 from ESL import ESLconnection

freeswitch/ESL/__init__.py in <module>
----> 1 from .ESL import ESLconnection

~/freeswitch/ESL/ESL.py in <module>
     26                 fp.close()
     27             return _mod
---> 28     _ESL = swig_import_helper()
     29     del swig_import_helper
     30 else:

~/freeswitch/ESL/ESL.py in swig_import_helper()
     22         if fp is not None:
     23             try:
---> 24                 _mod = imp.load_module('_ESL', fp, pathname, description)
     25             finally:
     26                 fp.close()

~/.venv/ajinkya/lib/python3.7/imp.py in load_module(name, file, filename, details)
    240                 return load_dynamic(name, filename, opened_file)
    241         else:
--> 242             return load_dynamic(name, filename, file)
    243     elif type_ == PKG_DIRECTORY:
    244         return load_package(name, filename)

~/.venv/ajinkya/lib/python3.7/imp.py in load_dynamic(name, path, file)
    340         spec = importlib.machinery.ModuleSpec(
    341             name=name, loader=loader, origin=path)
--> 342         return _load(spec)
    343
    344 else:

ImportError: dynamic module does not define module export function (PyInit__ESL)

System information:
OS: Debian 10
Python: 3.7.9
Freeswitch: 1.10.5

[Ajinkya009]

Thank you for the patch @mochouinard. We manually entered all the changes mentioned in the patch and then built the library. But when we try to import it, we get following errors:

ImportError                               Traceback (most recent call last)
<ipython-input-2-a536c87db710> in <module>
----> 1 from ESL import ESLconnection

freeswitch/ESL/__init__.py in <module>
----> 1 from .ESL import ESLconnection

~/freeswitch/ESL/ESL.py in <module>
     26                 fp.close()
     27             return _mod
---> 28     _ESL = swig_import_helper()
     29     del swig_import_helper
     30 else:

~/freeswitch/ESL/ESL.py in swig_import_helper()
     22         if fp is not None:
     23             try:
---> 24                 _mod = imp.load_module('_ESL', fp, pathname, description)
     25             finally:
     26                 fp.close()

~/.venv/ajinkya/lib/python3.7/imp.py in load_module(name, file, filename, details)
    240                 return load_dynamic(name, filename, opened_file)
    241         else:
--> 242             return load_dynamic(name, filename, file)
    243     elif type_ == PKG_DIRECTORY:
    244         return load_package(name, filename)

~/.venv/ajinkya/lib/python3.7/imp.py in load_dynamic(name, path, file)
    340         spec = importlib.machinery.ModuleSpec(
    341             name=name, loader=loader, origin=path)
--> 342         return _load(spec)
    343
    344 else:

ImportError: dynamic module does not define module export function (PyInit__ESL)

System information:
OS: Debian 10
Python: 3.7.9
Freeswitch: 1.10.5

If anyone else comes across this issue, please check if python3-dev package is installed. We were able to fix this issue by installing the package.

[mjerris]

make swigall should fix those issues I think, give it a try after you apply the patch

[MaartenUreel]

Any update on this? Will it be merged in FS?

[mdemille]

Been 3 months, commenting for a bump.

Any update on getting this merged? It's going to become quite the problem when OS's start dropping python2 support...

[andywolk]

Please resolve conflicts

[MaartenUreel]

@andywolk is this expected to be merged soon? I see that all the checks have passed and that you have approved it earlier.

We are very eager to start testing it out :)

[andywolk]

Thank you for your PR. Unfortunatelly there were much more work than just taking this as is. I am closing this as we finally added Python3 support. See latest commits in master.

[MaartenUreel]

Great news, thanks!