-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New repository structure #197
Comments
A few days ago I requested prysmatic labs to move their SSZ lib to its own repo, and I would like to see the same here. Not only as an effort to prevent bigger change-sets for releases to either library, but also to invite community projects to contribute back to the common libraries. See Prysm issue: prysmaticlabs/prysm#1549 |
Our current thinking is that there are quite a few such libraries that will be cross-project such that it would be infeasible to maintain a separate repo for each individually. |
All of these files have been moved to either: - https://github.com/sigp/lighthouse-beacon - https://github.com/sigp/lighthouse-validator - https://github.com/sigp/lighthouse-common For rationale, see: #197
Accidental close -- I subconsciously clicked "close" because I wanted to abandon the message I was typing. Oops! |
Problem
Whenever we need to bump up a spec version, it requires a single PR to update the entire repository, including eth2 libraries, the beacon node binary and the validator client binary.
The present all-in-one repository structure means that updates to the spec:
Solution
We (@AgeManning, @spble and I) propose to spawn three new repos from the present lighthouse repository. Here are their names and purposes:
sigp/lighthouse
(the existing one, here): contains all other repositories as git submodules, provides integration testing and likely some form orchestration scripts (docker, etc). It will also serve as the "landing page" for the other repos -- it will provide help/support and direct users to the other repos. If people choose to raise issues there that belong on another repo, we can just transfer the issue there using the Github beta transfer feature.sigp/lighthouse-beacon
: contains the beacon node binary.sigp/lighthouse-validator
: contains the validator client binary.sigp/lighthouse-common
: contains the presenteth2
dir and will contain crates that are common to the other crates (e.g., state-less spec logic, ssz, protos, ??)Downsides
Upsides
The text was updated successfully, but these errors were encountered: