Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix typo in advanced networking docs #2412

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix typo in advanced networking docs #2412

wants to merge 2 commits into from

Conversation

platschi
Copy link
Contributor

Proposed Changes

Fixing a typo in the advanced networking docs which mentions --target-peer instead of the correct --target-peers flag

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@platschi platschi changed the base branch from stable to unstable June 18, 2021 15:51
paulhauner
paulhauner approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

bors r+

@bors
Copy link

bors bot commented Jun 21, 2021

👎 Rejected by PR status

@paulhauner paulhauner added the ready-for-merge This PR is ready to merge. label Jun 21, 2021
@paulhauner paulhauner changed the base branch from unstable to stable June 21, 2021 04:55
@paulhauner paulhauner changed the base branch from stable to unstable June 21, 2021 04:56
@paulhauner
Copy link
Member

Sorry @platschi, I think Github is having trouble figuring out that this branch actually targets unstable now 🤔 Do you mind pushing an empty commit to see if that fixes it? 🙏

@paulhauner paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Jun 21, 2021
@platschi
Copy link
Contributor Author

Sorry @platschi, I think Github is having trouble figuring out that this branch actually targets unstable now thinking Do you mind pushing an empty commit to see if that fixes it? pray

Sorry, my bad. Empty commit just pushed 🚀

@paulhauner
Copy link
Member

Sorry, my bad.

No worries! Github is a bit awkward here, we can't specify a default branch for PRs (that's different to our "homepage" default) and it can't detect properly when the branch is changed.

Thanks again for the typo fix!

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jun 22, 2021
bors bot pushed a commit that referenced this pull request Jun 22, 2021
@platschi
Fix typo in advanced networking docs (#2412)
2357a41 
## Proposed Changes

Fixing a typo in the advanced networking docs which mentions ``--target-peer`` instead of the correct ``--target-peers`` flag
@bors
Copy link

bors bot commented Jun 22, 2021

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Fix typo in advanced networking docs [Merged by Bors] - Fix typo in advanced networking docs Jun 22, 2021
@bors bors bot closed this Jun 22, 2021
@platschi platschi deleted the advanced-networking-doc branch June 23, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@platschi @CLAassistant @paulhauner