Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for ActiveSamplingRequest #6307

Merged
merged 8 commits into from
Oct 4, 2024
Merged

Add test for ActiveSamplingRequest #6307

merged 8 commits into from
Oct 4, 2024

Conversation

ackintosh
Copy link
Member

Issue Addressed

I've implemented batching sampling requests in #6256, but there are no unit tests for it yet.

Proposed Changes

Add a test for ActiveSamplingRequest to ensure that the requests are batched, and check the status of the requests.

@ackintosh ackintosh added ready-for-review The code is ready for review das Data Availability Sampling labels Aug 26, 2024
@mergify mergify bot deleted the branch sigp:unstable August 27, 2024 04:10
@mergify mergify bot closed this Aug 27, 2024
@michaelsproul michaelsproul reopened this Aug 27, 2024
@michaelsproul
Copy link
Member

Please update to point at unstable by either:

  1. Rebasing on unstable (if your branch has a small number of commits that are easy to tease out), or
  2. Merging origin/das into this PR: git fetch origin; git merge origin/das. This will result in the smallest number of conflict resolutions and is better for branches that already contain merge commits or have extensive history.

@ackintosh ackintosh force-pushed the add-test-for-active-sampling-request branch from 556b0a9 to e0b6b2b Compare August 27, 2024 22:24
@ackintosh ackintosh changed the base branch from das to unstable August 27, 2024 22:25
@ackintosh
Copy link
Member Author

Thanks for the comment Michael! I've rebased this on unstable.

dapplion
dapplion reviewed Aug 28, 2024
View reviewed changes
beacon_node/network/src/sync/sampling.rs Outdated
}

#[test]
fn test_active_sampling_request() {
Copy link
Collaborator

@dapplion dapplion Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write tests in this format and file?

lighthouse/beacon_node/network/src/sync/block_lookups/tests.rs

Line 2011 in 5a96687

fn custody_lookup_happy_path() {

We recently avoided adding unit tests too close to impl for event-based tests

@ackintosh
Copy link
Member Author

Thanks @dapplion! I've written tests in the tests.rs file.

jimmygchen
jimmygchen approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test, very tidy 🎉

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 4, 2024
@jimmygchen
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Oct 4, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8cf686f

@mergify mergify bot merged commit 8cf686f into sigp:unstable Oct 4, 2024
28 checks passed
@ackintosh ackintosh deleted the add-test-for-active-sampling-request branch October 4, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion left review comments

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
das Data Availability Sampling ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ackintosh @michaelsproul @jimmygchen @dapplion