Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite deposit_contract crate using alloy #6366

Open
wants to merge 4 commits into
base: unstable
Choose a base branch
from
Open

Rewrite deposit_contract crate using alloy #6366

wants to merge 4 commits into from
+229 −267

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Part of:

Proposed Changes

Switch the deposit_contract crate off ethabi and onto alloy-json-abi. The translation was mostly fairly straightforward.

Additional Info

This PR builds upon:

After this there's just one more place to purge ethers/ethabi from: the execution layer integration tests.

@michaelsproul michaelsproul added blocked code-quality dependencies Pull requests that update a dependency file labels Sep 6, 2024
@michaelsproul michaelsproul added work-in-progress PR is a work-in-progress and removed blocked labels Sep 6, 2024
@michaelsproul
Copy link
Member Author

Some more work to do here. The eth1_test_rig is quite integrated with deposit_contract and needs an update

@michaelsproul michaelsproul mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-quality dependencies Pull requests that update a dependency file work-in-progress PR is a work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaelsproul