Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy Eth2Config generation at runtime #912

Merged
merged 18 commits into from
Apr 2, 2020
Merged

Tidy Eth2Config generation at runtime #912

merged 18 commits into from
Apr 2, 2020

Commits on Mar 15, 2020

  1. Move the codes that loads Eth2Config from config to environment

    @ackintosh
    ackintosh committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    30bdf7e View commit details
    Browse the repository at this point in the history

  2. Move the codes that setups Eth2Config for testnet

    @ackintosh
    ackintosh committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    e243332 View commit details
    Browse the repository at this point in the history

  3. Move the codes that creates a new ChainSpec

    @ackintosh
    ackintosh committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    150b18d View commit details
    Browse the repository at this point in the history

  4. Remove unused mut

    @ackintosh
    ackintosh committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    a0e70d0 View commit details
    Browse the repository at this point in the history

  5. Reduce local variable number

    @ackintosh
    ackintosh committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    9be4563 View commit details
    Browse the repository at this point in the history

  6. Remove unused outputs of config::get_configs()

    @ackintosh
    ackintosh committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    889d683 View commit details
    Browse the repository at this point in the history

  7. Change the method name from plural to singular

    @ackintosh
    ackintosh committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    5e720e9 View commit details
    Browse the repository at this point in the history

  8. DRY the const ETH2_CONFIG_FILENAME

    @ackintosh
    ackintosh committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    d33003b View commit details
    Browse the repository at this point in the history

  9. Add comments

    @ackintosh
    ackintosh committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    74d0193 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary blank line

    @ackintosh
    ackintosh committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    4fffda7 View commit details
    Browse the repository at this point in the history

  11. cargo fmt

    @ackintosh
    ackintosh committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    9151025 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Merge branch 'master' into tidy-eth2config-generation

    @ackintosh
    ackintosh committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    e4eecc4 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Merge remote-tracking branch 'upstream/master' into tidy-eth2config-g… 

    …eneration
    @ackintosh
    ackintosh committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    d9fd99b View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Add tests for EnvironmentBuilder::setup_eth2_config()

    @ackintosh
    ackintosh committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    50a923a View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2020

  1. Remove the comment that have been fixed

    @ackintosh
    ackintosh committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    7d68ca2 View commit details
    Browse the repository at this point in the history

  2. Reduce local variable

    @ackintosh
    ackintosh committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    fc391fe View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Remove redundant local variable

    @ackintosh
    ackintosh committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    2b06466 View commit details
    Browse the repository at this point in the history

  2. Remove prysm-specific codes 

    Now the spec is in the eth2-testnets repo
    @ackintosh
    ackintosh committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    2502a17 View commit details
    Browse the repository at this point in the history