Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigstore-conformance: add jku as maintainer #334

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

woodruffw
Copy link
Member

Per Slack discussion: this adds another maintainer to https://github.com/sigstore-conformance/extremely-dangerous-public-oidc-beacon.

Specifically, it adds @jku (who is already a Sigstore contributor + trusted reviewer).

Shouldn't be merged until @jku actually agrees to accept the maintain bit here -- I don't want to sign him up for things arbitrarily. This is mostly to make sure that PRs to this repo have a slightly larger reviewer timezone window (since I'm US EST and @tetsuo-cpp is Australia EST).

Signed-off-by: William Woodruff <william@trailofbits.com>
@github-actions
Copy link

🍹 preview on sigstore-github-sync/sigstore/github-sigstore-conformance

Pulumi report
Previewing update (sigstore/github-sigstore-conformance)

View Live: https://app.pulumi.com/sigstore/sigstore-github-sync/github-sigstore-conformance/previews/f702ef50-b97a-4de4-bda3-88f552d6bb47

@ Previewing update......
pulumi:pulumi:Stack: (same)
[urn=urn:pulumi:github-sigstore-conformance::sigstore-github-sync::pulumi:pulumi:Stack::sigstore-github-sync-github-sigstore-conformance]
+ github:index/repositoryCollaborator:RepositoryCollaborator: (create)
    [urn=urn:pulumi:github-sigstore-conformance::sigstore-github-sync::github:index/repositoryCollaborator:RepositoryCollaborator::extremely-dangerous-public-oidc-beacon-jku]
    permission               : "maintain"
    permissionDiffSuppression: false
    repository               : "extremely-dangerous-public-oidc-beacon"
    username                 : "jku"
Resources:
+ 1 to create
15 unchanged

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@woodruffw
Copy link
Member Author

Thanks @jku! CC @cpanato @haydentherapper for approval 🙂

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no power to approve :)

@cpanato
Copy link
Member

cpanato commented Sep 29, 2023

I think next step is to create a team and add the maintainers there.
I will do that

@cpanato cpanato merged commit da86a96 into sigstore:main Sep 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants