-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codeowners for sigstore-go #335
Conversation
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
FYI @phillmv |
🍹
|
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
FYI @kommendorkapten |
I see Cody and Zach are already on there as codeowners, lgtm! |
Actually, @haydentherapper, these dynamics are invisible to you 😉 but we're all paid to collaborate on the same systems towards the same goals, so… what if?
|
Maintainers are expected to have made contributions to the repository, so we shouldn't be adding such a broad set of reviewers unless they have made significant changes and are planning to be active on triage and reviews. Also, given that this project will be donated to the Sigstore community, we should encourage a diverse set of maintainers with respect to the companies they work for. As for sigstore-js, I would chat with the owners about adding you, I don't want to make proposals for projects I don't work on. |
@haydentherapper in general I of course agree that we need to prove out contribution dynamics before adding folks from the community as contributors on a repo, but in this case we're talking about a cohort of Hubbers who were/are instrumental in the review processes that were part of the creation of the sigstore-go library that GitHub is donating to Sigstore. I'm loathe to give up that momentum! 😄 Plz hmu on Slack if you have concerns. |
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
I've added others as reviewers, who can review and approve PRs. |
Thanks y’all, please merge. |
Summary
Release Note
Documentation