Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners for sigstore-go #335

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

haydentherapper
Copy link
Contributor

Summary

Release Note

Documentation

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper
Copy link
Contributor Author

FYI @phillmv

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

🍹 preview on sigstore-github-sync/sigstore/github-prod

Pulumi report
Previewing update (sigstore/github-prod)

View Live: https://app.pulumi.com/sigstore/sigstore-github-sync/github-prod/previews/6889111c-7e93-4cfa-9158-2f1a116dc306

@ Previewing update......
pulumi:pulumi:Stack: (same)
[urn=urn:pulumi:github-prod::sigstore-github-sync::pulumi:pulumi:Stack::sigstore-github-sync-github-prod]
+ github:index/membership:Membership: (create) 🔒
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/membership:Membership::phillmv]
    downgradeOnDestroy: false
    role              : "member"
    username          : "phillmv"
+ github:index/teamMembership:TeamMembership: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamMembership:TeamMembership::kommendorkapten-sigstore-go-codeowners]
    role      : "member"
    teamId    : "6980777"
    username  : "kommendorkapten"
+ github:index/teamMembership:TeamMembership: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/teamMembership:TeamMembership::phillmv-sigstore-go-codeowners]
    role      : "member"
    teamId    : "6980777"
    username  : "phillmv"
+-github:index/repositoryCollaborator:RepositoryCollaborator: (replace)
    [id=helm-charts:priyawadhwa]
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repositoryCollaborator:RepositoryCollaborator::helm-charts-priyawadhwa]
  ~ permission: "admin" => "maintain"
+-github:index/repositoryCollaborator:RepositoryCollaborator: (replace)
    [id=public-good-instance:loosebazooka]
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repositoryCollaborator:RepositoryCollaborator::public-good-instance-loosebazooka]
  ~ permission: "triage" => "pull"
+-github:index/repositoryCollaborator:RepositoryCollaborator: (replace)
    [id=public-good-instance:priyawadhwa]
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repositoryCollaborator:RepositoryCollaborator::public-good-instance-priyawadhwa]
  ~ permission: "admin" => "maintain"
+-github:index/repositoryCollaborator:RepositoryCollaborator: (replace)
    [id=public-good-instance:trevrosen]
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repositoryCollaborator:RepositoryCollaborator::public-good-instance-trevrosen]
  ~ permission: "admin" => "pull"
@ Previewing update....
+-github:index/repositoryCollaborator:RepositoryCollaborator: (replace)
    [id=sigstore-conformance:di]
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repositoryCollaborator:RepositoryCollaborator::sigstore-conformance-di]
  ~ permission: "maintain" => "push"
+ github:index/repositoryCollaborator:RepositoryCollaborator: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repositoryCollaborator:RepositoryCollaborator::sigstore-go-bdehamer]
    permission               : "push"
    permissionDiffSuppression: false
    repository               : "sigstore-go"
    username                 : "bdehamer"
+ github:index/repositoryCollaborator:RepositoryCollaborator: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repositoryCollaborator:RepositoryCollaborator::sigstore-go-malancas]
    permission               : "push"
    permissionDiffSuppression: false
    repository               : "sigstore-go"
    username                 : "malancas"
+ github:index/repositoryCollaborator:RepositoryCollaborator: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repositoryCollaborator:RepositoryCollaborator::sigstore-go-ejahnGithub]
    permission               : "push"
    permissionDiffSuppression: false
    repository               : "sigstore-go"
    username                 : "ejahnGithub"
+ github:index/repositoryCollaborator:RepositoryCollaborator: (create)
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/repositoryCollaborator:RepositoryCollaborator::sigstore-go-feelepxyz]
    permission               : "push"
    permissionDiffSuppression: false
    repository               : "sigstore-go"
    username                 : "feelepxyz"
Resources:
+ 7 to create
+-5 to replace
12 changes. 562 unchanged

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper haydentherapper changed the title Add codeowner for sigstore-go Add codeowners for sigstore-go Sep 28, 2023
@haydentherapper
Copy link
Contributor Author

FYI @kommendorkapten

@phillmv
Copy link
Member

phillmv commented Sep 28, 2023

I see Cody and Zach are already on there as codeowners, lgtm!

@phillmv
Copy link
Member

phillmv commented Sep 28, 2023

Actually, @haydentherapper, these dynamics are invisible to you 😉 but we're all paid to collaborate on the same systems towards the same goals, so… what if?

  • you could add @malancas, @bdehamer, @ejahnGithub and @feelepxyz to sigstore-go reviewers
  • add myself to sigstore.js (I once wasted a half hour reviewing a sigstore.js PR it turned out I could not approve 😝)

@haydentherapper
Copy link
Contributor Author

haydentherapper commented Sep 28, 2023

Maintainers are expected to have made contributions to the repository, so we shouldn't be adding such a broad set of reviewers unless they have made significant changes and are planning to be active on triage and reviews.

Also, given that this project will be donated to the Sigstore community, we should encourage a diverse set of maintainers with respect to the companies they work for.

As for sigstore-js, I would chat with the owners about adding you, I don't want to make proposals for projects I don't work on.

@trevrosen
Copy link
Contributor

@haydentherapper in general I of course agree that we need to prove out contribution dynamics before adding folks from the community as contributors on a repo, but in this case we're talking about a cohort of Hubbers who were/are instrumental in the review processes that were part of the creation of the sigstore-go library that GitHub is donating to Sigstore. I'm loathe to give up that momentum! 😄 Plz hmu on Slack if you have concerns.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper
Copy link
Contributor Author

haydentherapper commented Sep 28, 2023

I've added others as reviewers, who can review and approve PRs.

@haydentherapper
Copy link
Contributor Author

Thanks y’all, please merge.

@bobcallaway bobcallaway merged commit 5bc2492 into sigstore:main Sep 29, 2023
3 checks passed
@haydentherapper haydentherapper deleted the go-codeowners branch October 2, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants