Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pivtool generate key touch policy #2282

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Sep 26, 2022

Summary

  • fix pivtool generate key touch policy

Fixes: #2214

Signed-off-by: cpanato <ctadeu@gmail.com>
Copy link
Member

@developer-guy developer-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cpanato cpanato merged commit d720f04 into sigstore:main Sep 26, 2022
@cpanato cpanato deleted the GH-2214 branch September 26, 2022 14:44
@github-actions github-actions bot added this to the v1.13.0 milestone Sep 26, 2022
cpanato added a commit that referenced this pull request Sep 27, 2022
* fix pivtool generate key touch policy (#2282)

Signed-off-by: cpanato <ctadeu@gmail.com>

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: RTann <rtannenb@redhat.com>

* fix race condition in FetchSignaturesForReference

Signed-off-by: RTann <rtannenb@redhat.com>

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: RTann <rtannenb@redhat.com>
Co-authored-by: Carlos Tadeu Panato Junior <ctadeu@gmail.com>
jeff-mccoy referenced this pull request in zarf-dev/zarf Oct 7, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/sigstore/cosign](https://togithub.com/sigstore/cosign) |
require | minor | `v1.12.1` -> `v1.13.0` |

---

### Release Notes

<details>
<summary>sigstore/cosign</summary>

###
[`v1.13.0`](https://togithub.com/sigstore/cosign/blob/HEAD/CHANGELOG.md#v1130)

[Compare
Source](https://togithub.com/sigstore/cosign/compare/v1.12.1...v1.13.0)

> # Highlights
>
> - For users who have deployed a private instance of Fulcio release
v0.6.x and issue certificates with the Username identity, you will need
to upgrade to use this version."

#### Enhancements

- Add support for Fulcio username identity in SAN
([https://github.com/sigstore/cosign/pull/2291](https://togithub.com/sigstore/cosign/pull/2291))
- Data race in FetchSignaturesForReference
([https://github.com/sigstore/cosign/pull/2283](https://togithub.com/sigstore/cosign/pull/2283))
- Check error on chain verification failure
([https://github.com/sigstore/cosign/pull/2284](https://togithub.com/sigstore/cosign/pull/2284))
- feat: improve the verification message
([https://github.com/sigstore/cosign/pull/2268](https://togithub.com/sigstore/cosign/pull/2268))
- feat: use stdin as an input for predicate
([https://github.com/sigstore/cosign/pull/2269](https://togithub.com/sigstore/cosign/pull/2269))

#### Bug Fixes

- fix: make tlog entry lookups for online verification shard-aware
([https://github.com/sigstore/cosign/pull/2297](https://togithub.com/sigstore/cosign/pull/2297))
- Fix: Create a static copy of signatures as part of verification.
([https://github.com/sigstore/cosign/pull/2287](https://togithub.com/sigstore/cosign/pull/2287))
- Fix: Remove an extra registry request from verification path.
([https://github.com/sigstore/cosign/pull/2285](https://togithub.com/sigstore/cosign/pull/2285))
- fix pivtool generate key touch policy
([https://github.com/sigstore/cosign/pull/2282](https://togithub.com/sigstore/cosign/pull/2282))

#### Others

- use scaffolding 0.4.8 for tests.
([https://github.com/sigstore/cosign/pull/2280](https://togithub.com/sigstore/cosign/pull/2280))

#### Contributors

-   Asra Ali ([@&#8203;asraa](https://togithub.com/asraa))
- Batuhan Apaydın
([@&#8203;developer-guy](https://togithub.com/developer-guy))
- Carlos Tadeu Panato Junior
([@&#8203;cpanato](https://togithub.com/cpanato))
- Hayden Blauzvern
([@&#8203;haydentherapper](https://togithub.com/haydentherapper))
-   Matt Moore ([@&#8203;mattmoor](https://togithub.com/mattmoor))
-   Ross Tannenbaum ([@&#8203;RTann](https://togithub.com/RTann))
-   Ville Aikas ([@&#8203;vaikas](https://togithub.com/vaikas))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMjIuMyIsInVwZGF0ZWRJblZlciI6IjMyLjIyMi4zIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Noxsios referenced this pull request in zarf-dev/zarf Mar 8, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/sigstore/cosign](https://togithub.com/sigstore/cosign) |
require | minor | `v1.12.1` -> `v1.13.0` |

---

### Release Notes

<details>
<summary>sigstore/cosign</summary>

###
[`v1.13.0`](https://togithub.com/sigstore/cosign/blob/HEAD/CHANGELOG.md#v1130)

[Compare
Source](https://togithub.com/sigstore/cosign/compare/v1.12.1...v1.13.0)

> # Highlights
>
> - For users who have deployed a private instance of Fulcio release
v0.6.x and issue certificates with the Username identity, you will need
to upgrade to use this version."

#### Enhancements

- Add support for Fulcio username identity in SAN
([https://github.com/sigstore/cosign/pull/2291](https://togithub.com/sigstore/cosign/pull/2291))
- Data race in FetchSignaturesForReference
([https://github.com/sigstore/cosign/pull/2283](https://togithub.com/sigstore/cosign/pull/2283))
- Check error on chain verification failure
([https://github.com/sigstore/cosign/pull/2284](https://togithub.com/sigstore/cosign/pull/2284))
- feat: improve the verification message
([https://github.com/sigstore/cosign/pull/2268](https://togithub.com/sigstore/cosign/pull/2268))
- feat: use stdin as an input for predicate
([https://github.com/sigstore/cosign/pull/2269](https://togithub.com/sigstore/cosign/pull/2269))

#### Bug Fixes

- fix: make tlog entry lookups for online verification shard-aware
([https://github.com/sigstore/cosign/pull/2297](https://togithub.com/sigstore/cosign/pull/2297))
- Fix: Create a static copy of signatures as part of verification.
([https://github.com/sigstore/cosign/pull/2287](https://togithub.com/sigstore/cosign/pull/2287))
- Fix: Remove an extra registry request from verification path.
([https://github.com/sigstore/cosign/pull/2285](https://togithub.com/sigstore/cosign/pull/2285))
- fix pivtool generate key touch policy
([https://github.com/sigstore/cosign/pull/2282](https://togithub.com/sigstore/cosign/pull/2282))

#### Others

- use scaffolding 0.4.8 for tests.
([https://github.com/sigstore/cosign/pull/2280](https://togithub.com/sigstore/cosign/pull/2280))

#### Contributors

-   Asra Ali ([@&#8203;asraa](https://togithub.com/asraa))
- Batuhan Apaydın
([@&#8203;developer-guy](https://togithub.com/developer-guy))
- Carlos Tadeu Panato Junior
([@&#8203;cpanato](https://togithub.com/cpanato))
- Hayden Blauzvern
([@&#8203;haydentherapper](https://togithub.com/haydentherapper))
-   Matt Moore ([@&#8203;mattmoor](https://togithub.com/mattmoor))
-   Ross Tannenbaum ([@&#8203;RTann](https://togithub.com/RTann))
-   Ville Aikas ([@&#8203;vaikas](https://togithub.com/vaikas))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMjIuMyIsInVwZGF0ZWRJblZlciI6IjMyLjIyMi4zIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The --touch-policy does not work in the piv-tool
3 participants