Add interactive flow to credential cache. #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlynch
force-pushed
the
cache-interactive
branch
from
15b0f73
to
505d8d0
Compare
|
cc @kaniini |
This allows for the cache socket to be passed through an SSH client to allow for remote sessions to use the cache to fetch credentials with the interactive flow. Signed-off-by: Billy Lynch <billy@chainguard.dev>
wlynch
force-pushed
the
cache-interactive
branch
from
505d8d0
to
c7fcc31
Compare
|
Total gamechanger for using gitsign on remote machines. Thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to let the credential cache to go through the interactive flow if a credential is not found.
This is mostly refactoring to share the interactive flow between the cache and gitsign directly and prevent import cycles.
This allows for the cache socket to be passed through an SSH session to allow for remote sessions to use the cache to fetch credentials with the local client interactive flow (i.e. you can use your local browser to authenticate and cache credentials for a remote session).
Testing around this is weak at the moment - I want to look into setting up scaffolding to allow easier integration tests against test instances, but this will happen in a different PR.
Fixes #190
Release Note
Credential cache to go through the interactive flow if a credential is not found. When paired with SSH socket forwarding, this can be used to use your local browser to authenticate and cache credentials for a remote session.
Documentation
✅