update tough dep #340
Merged
update tough dep #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once awslabs/tough#759 Merges I'll be able to use the tagged release version of tough here 🥳 |
|
cc @Xynnn007 and @kommendorkapten for reviews |
|
Touch point we're using this downstream in bpfman/bpfman#1042 |
|
also cc @flavio |
flavio
requested changes
Mar 26, 2024
|
@astoycos thanks a lot for having created this PR. I left some comments, please make sure all the tests are passing |
|
Great news, a new tough release is out: https://github.com/awslabs/tough/releases/tag/tough-v0.17.1 |
flavio
requested changes
Mar 27, 2024
|
Thanks for the reviews @flavio! |
This commit updates the tough dependency, which changes how many of our trait definitions work. Additionally move from the use of std::sync::oncecell to tokio::sync::oncecell for sigstoretrustroot.trusted_root so that SigstoreTrustRoot can be Send. Update examples and tests. Remove some unused types Fixup clippy warnings Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
|
I'm waiting for all the tests to be green, then I'll merge it :) |
flavio
approved these changes
Mar 27, 2024
flavio
added a commit
to flavio/sigstore-rs
that referenced
this pull request
Mar 27, 2024
== What's Changed * sign: init by @jleightcap in sigstore#310 * cargo audit: ignore RUSTSEC-2023-0071 by @jleightcap in sigstore#321 * chore(deps): Update json-syntax requirement from 0.9.6 to 0.10.0 by @dependabot in sigstore#319 * chore(deps): Update cached requirement from 0.46.0 to 0.47.0 by @dependabot in sigstore#323 * chore(deps): Update serial_test requirement from 2.0.0 to 3.0.0 by @dependabot in sigstore#322 * dep: update rustls-webpki, fold in pki_types by @jleightcap in sigstore#324 * chore(deps): Update cached requirement from 0.47.0 to 0.48.0 by @dependabot in sigstore#325 * chore(deps): Update json-syntax requirement from 0.10.0 to 0.11.1 by @dependabot in sigstore#327 * chore(deps): Update cached requirement from 0.48.0 to 0.49.2 by @dependabot in sigstore#329 * chore(deps): Update json-syntax requirement from 0.11.1 to 0.12.2 by @dependabot in sigstore#330 * lint: fix lint error of chrono and tokio by @Xynnn007 in sigstore#334 * chore(deps): Update base64 requirement from 0.21.0 to 0.22.0 by @dependabot in sigstore#332 * The `Repository` trait and `ManualRepository` struct no longer require a feature flag by @tannaurus in sigstore#331 * chore(deps): Bump actions/checkout from 4.1.1 to 4.1.2 by @dependabot in sigstore#336 * chore(deps): Update reqwest requirement from 0.11 to 0.12 by @dependabot in sigstore#341 * update tough dep by @astoycos in sigstore#340 == New Contributors * @tannaurus made their first contribution in sigstore#331 * @astoycos made their first contribution in sigstore#340 **Full Changelog**: sigstore/sigstore-rs@v0.8.0...v0.9.0 Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DO NOT MERGE UNTIL awslabs/tough#755 merges and the fixed crate to @kommendorkapten is updatedawslabs/tough#755 merged but still isn't in a released version
Rebases and updates #320
This commit updates the tough dependency, which
changes how many of our trait definitions work.
Additionally move from the use of
oncecell to oncelock for sigstoretrustroot.trusted_root
so that SigstoreTrustRoot can be Send.
Update examples and tests.
Manual fix for #317 and #337
Fixes #338
Release Note
Documentation