add(Checkbox): add name and value attributes and expose change event #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobbitronics
requested review from
briskt,
forevermatt,
mtompset and
jason-jackson
and removed request for
a team
|
briskt
approved these changes
May 5, 2025
| }) | ||
| const handleChange = () => dispatch(checkbox.checked ? 'checked' : 'unchecked') | ||
| $: if (checkbox && checkbox.checked !== checked) { |
There was a problem hiding this comment.
Can this be checkbox?.checked?
There was a problem hiding this comment.
actually I don't think that's equivalent because if checkbox is undefined then the block won't run, but if checked is undefined it will as long as checked isn't undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ETH-1160 fix consistency of Checkbox api with html checkbox
Added
Changed
Security
npm audit fixFeature branch checklist
make format,make dryandmake install