Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of the keymaps dialog plugin #1601

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Conversation

SuperDelphi
Copy link
Contributor

@SuperDelphi SuperDelphi commented May 29, 2024

I've added the integration of the GrapesJS Keymaps Dialog plugin. I also replaced the brackets surrounding the shortcuts' hints with parenthesis (since the native buttons use them apparently).

⚠️ Before merging this, it is necessary to first merge this pull request, from the plugin repository. Additionally, the plugin needs to be published on NPM, which isn't the case yet. @lexoyo Does the publish.yml work correctly?

package.json Outdated Show resolved Hide resolved
Copy link
Contributor Author

@SuperDelphi SuperDelphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ready for review (a check failed because the plugin isn't published on NPM yet)!

package.json Outdated Show resolved Hide resolved
@SuperDelphi SuperDelphi requested a review from lexoyo June 3, 2024 07:27
@lexoyo lexoyo merged commit 7a1359e into silexlabs:dev Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants