Skip to content

Removing DIFF parameter in la_odiff/la_idiff #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

Removing DIFF parameter in la_odiff/la_idiff #98

merged 1 commit into from
Mar 5, 2025

Conversation

aolofsson
Copy link
Member

  • Didn't make sense
  • A cell is either differential or it's not, should not be part of a differential cell generator...

@aolofsson
Removing DIFF parameter
0798293 
- Didn't make sense
- A cell is either differential or it's not, should not be part of a differential cell generator...
@gadfort
Copy link
Member

gadfort commented Mar 5, 2025

@aolofsson this applies to the idiff cell too

gadfort
gadfort approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@gadfort gadfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to do the idiff one as well, but otherwise looks good to me

@aolofsson aolofsson changed the title Removing DIFF parameter in la_odiff Removing DIFF parameter in la_odiff/la_idiff Mar 5, 2025
@aolofsson aolofsson merged commit 96c2918 into main Mar 5, 2025
3 checks passed
@aolofsson aolofsson deleted the ddr branch March 5, 2025 21:29
@aolofsson
Copy link
Member Author

Member

yes, both were fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadfort gadfort gadfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aolofsson @gadfort