Accept headers + ToResponseCode #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of manually wrapping it. Fixes a bug where reusing a deserialized error would throw an exception
…rmal usage from needing an explicit rest-types dependency
… error types differ
…ponse property of the error object
|
Except for the testing part, I think I'm done for now. Would appreciate a code review! |
bergmark
force-pushed
the
accept-headers
branch
from
e2b23ea
to
7940f84
Compare
bergmark
force-pushed
the
accept-headers
branch
from
893987e
to
a9ee728
Compare
… header for files
…ot semicolons), and use application/octet-stream as the accept header for file outputs
bergmark
force-pushed
the
accept-headers
branch
from
63a49c3
to
79dccf1
Compare
Conflicts: rest-core/CHANGELOG.md
bergmark
force-pushed
the
accept-headers
branch
from
5caa1d7
to
f51d2ea
Compare
bergmark
force-pushed
the
accept-headers
branch
from
f51d2ea
to
33f4990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is several bug fixes, and needs breaking changes in rest-types, rest-core, and rest-gen. I need to test this more thoroughly and clean it up before releasing it. Hopefully also write some automated regression tests.
The most important fixes are for these issues:
DomainReasonis partial (always contains anerrorinstead of the response code function)