Skip to content

Conversation

benjaminking
Copy link
Collaborator

@benjaminking benjaminking commented Sep 9, 2025

Unfortunately I forgot to include FileParatextProjectQuoteConventionDetector in __init__.py, so the released version is not usable in SILNLP for quote convention detection.

(By the way, is it better to create a new branch in cases like this or just modify the already merged branch?)


This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.10%. Comparing base (146f195) to head (4ac7b4e).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...file_paratext_project_quote_convention_detector.py 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   91.11%   91.10%   -0.02%     
==========================================
  Files         333      334       +1     
  Lines       21706    21720      +14     
==========================================
+ Hits        19778    19788      +10     
- Misses       1928     1932       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: In general, I'd say making a new branch is the easiest/best

@Enkidu93 reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @benjaminking)

@Enkidu93 Enkidu93 force-pushed the detect_quote_convention_for_file_pt_proj branch from 4ac7b4e to 6f973b4 Compare September 10, 2025 16:06
@Enkidu93
Copy link
Collaborator

I went ahead and rebased it. Like I said, if you just use a new branch, then you won't run into merge conflict issues like these (even if they're easy to resolve).

@Enkidu93 Enkidu93 merged commit 0e707ce into main Sep 10, 2025
13 of 14 checks passed
@Enkidu93 Enkidu93 deleted the detect_quote_convention_for_file_pt_proj branch September 10, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants