Skip to content

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Sep 17, 2025

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 91.22807% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.91%. Comparing base (f1778e1) to head (d39c7b0).

Files with missing lines Patch % Lines
...rpora/zip_paratext_project_settings_parser_base.py 76.19% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   90.88%   90.91%   +0.03%     
==========================================
  Files         335      337       +2     
  Lines       21474    21524      +50     
==========================================
+ Hits        19517    19569      +52     
+ Misses       1957     1955       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- fix loading of custom stylesheet from zip archive
- fixes #204
Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 1 of 3 files at r1, 1 of 4 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@ddaspit ddaspit merged commit 22c8d87 into main Sep 19, 2025
14 checks passed
@ddaspit ddaspit deleted the custom-stylesheet branch September 19, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-verse custom style markers are not removed from Scripture text rows

3 participants