-
-
Notifications
You must be signed in to change notification settings - Fork 3
Change quotation denormalizer to only use target corpus quote convention #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddaspit reviewed 23 of 23 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Enkidu93)
tests/punctuation_analysis/test_paratext_project_quote_convention_detector.py
line 6 at r1 (raw file):
from machine.corpora import ParatextProjectSettings, UsfmStylesheet from machine.punctuation_analysis.paratext_project_quote_convention_detector import (
These should be simplified to importing from machine.punctuation_analysis
instead of the modules.
tests/testutils/memory_paratext_project_quote_convention_detector.py
line 5 at r1 (raw file):
from machine.corpora import ParatextProjectSettings from machine.punctuation_analysis.paratext_project_quote_convention_detector import (
This should be simplified to importing from machine.punctuation_analysis
instead of the module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 24 files reviewed, 2 unresolved discussions (waiting on @ddaspit and @Enkidu93)
tests/testutils/memory_paratext_project_quote_convention_detector.py
line 5 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
This should be simplified to importing from
machine.punctuation_analysis
instead of the module.
Done.
tests/punctuation_analysis/test_paratext_project_quote_convention_detector.py
line 6 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
These should be simplified to importing from
machine.punctuation_analysis
instead of the modules.
Done.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 90.91% 90.91% -0.01%
==========================================
Files 337 337
Lines 21524 21519 -5
==========================================
- Hits 19569 19564 -5
Misses 1955 1955 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddaspit reviewed 20 of 20 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Enkidu93 reviewed 4 of 23 files at r1, 20 of 20 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @benjaminking)
This PR updates the quotation denormalizer to only make use the target corpus quote convention.
(Eli and I were discussing this the last few days and concluded that it's more appropriate to use the normalized version of the target corpus quote convention in place of the source corpus quote convention)
This also includes some reorganization, since moving the
punctuation_analysis
package was resulting in circular dependencies.This change is