improve JSON.stringify

[irahopkinson]

• BREAKING CHANGE - previously it just serialized the properties (no getters).
• BREAKING CHANGE - remove deprecated parse method
• bump to v2.0.0
• also update dependencies.
• also bump deprecated actions

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.22%. Comparing base (3bc5fbd) to head (92e2c91).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   84.70%   86.22%   +1.52%     
==========================================
  Files           4        4              
  Lines         353      363      +10     
  Branches      105      110       +5     
==========================================
+ Hits          299      313      +14     
+ Misses         52       50       -2     
+ Partials        2        0       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tjcouch-sil]

I don't really know the context behind why you are making this change, but it seems fine.

I do wonder, though, why choose to serialize with book instead of bookNum? Seems bookNum would give more consistency with the other fields. Doesn't really matter much, though, so I'm approving. I imagine you had a good reason anyway.

I don't have any changes in mind for v1.

Note: I think you may have to tune up VerseRefConverter in P.B to support this.

[lyonsil]

👍

[irahopkinson]

@tjcouch-sil Using book makes the serialized output more human readable than bookNum, e.g. it's really hard to know what bookNum=19 is but book="PSA" is more obvious.