Skip to content

Add bbbcccvvv support to VerseRef constructor #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

pmachapman
Copy link
Contributor

This PR adds support for bbbcccvvv values to the VerseRef constructor, enabling the unit test for this feature, and adding another unit test to test specifying the versification with the bbbcccvvv constructor.

@pmachapman pmachapman force-pushed the feature/verseref-bbbcccvvv branch from 168ecaf to 5da2d74 Compare July 17, 2023 04:10
@pmachapman pmachapman force-pushed the feature/verseref-bbbcccvvv branch from 5da2d74 to 18bd4b6 Compare July 17, 2023 04:24
Copy link
Collaborator

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@irahopkinson irahopkinson merged commit 48b859b into sillsdev:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants