-
-
Notifications
You must be signed in to change notification settings - Fork 29
Delta updates to minimize edit conflicts #1204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
12726a0
Add deep-diff NPM package
rmunn e84fd6f
Spot-check how deep-diff works
rmunn 4a7a16e
Delta updates mostly working
rmunn bd33cf4
Adding or removing senses or examples is non-delta
rmunn 1fc01de
Can now send diffs as Mongo updates
rmunn 3ff72eb
Delta updates now update authorInfo of entries
rmunn 4eb07e2
Attempted fix for LexMultiValues that don't exist
rmunn bf13843
Fix adding new items to arrays
rmunn 4fc19ec
Delta updates cannot have array changes at all
rmunn 8435474
Custom fields work now
rmunn fd8000c
Start of deep-diff unit tests
rmunn 90d28d8
Convenience: run only LexEntryCommands unit tests
rmunn bce93b1
Create test for swapping senses around
rmunn 98adf7f
Better test for swapping senses
rmunn 22863bd
Another swapping-senses test
rmunn 305238a
Better unit test names
rmunn 14eb2e0
Many more unit tests
rmunn e09f89e
Revert "Convenience: run only LexEntryCommands unit tests"
rmunn 04b2c6f
Remove entry->writeDiff() code path entirely
rmunn 985d8ce
Address review comments
rmunn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
memory_limit = 256M | ||
post_max_size = 60M | ||
upload_max_filesize = 60M | ||
xdebug.log_level = 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
--- a/var/www/html/vendor/symfony/debug/ExceptionHandler.php 2019-07-23 15:39:19.000000000 +0700 | ||
+++ b/var/www/html/vendor/symfony/debug/ExceptionHandler.php 2021-09-27 15:08:37.000000000 +0700 | ||
@@ -103,7 +103,7 @@ | ||
* The latter takes precedence and any output from the former is cancelled, | ||
* if and only if nothing bad happens in this handling path. | ||
*/ | ||
- public function handle(\Exception $exception) | ||
+ public function handle(\Error $exception) | ||
{ | ||
if (null === $this->handler || $exception instanceof OutOfMemoryException) { | ||
$this->sendPhpResponse($exception); | ||
@@ -144,7 +144,7 @@ | ||
try { | ||
\call_user_func($this->handler, $exception); | ||
$this->caughtLength = $caughtLength; | ||
- } catch (\Exception $e) { | ||
+ } catch (\Error $e) { | ||
if (!$caughtLength) { | ||
// All handlers failed. Let PHP handle that now. | ||
throw $exception; | ||
@@ -158,7 +158,7 @@ | ||
* This method uses plain PHP functions like header() and echo to output | ||
* the response. | ||
* | ||
- * @param \Exception|FlattenException $exception An \Exception or FlattenException instance | ||
+ * @param \Error|FlattenException $exception An \Error or FlattenException instance | ||
*/ | ||
public function sendPhpResponse($exception) | ||
{ | ||
@@ -180,7 +180,7 @@ | ||
/** | ||
* Gets the full HTML content associated with the given exception. | ||
* | ||
- * @param \Exception|FlattenException $exception An \Exception or FlattenException instance | ||
+ * @param \Error|FlattenException $exception An \Error or FlattenException instance | ||
* | ||
* @return string The HTML content as a string | ||
*/ | ||
@@ -250,7 +250,7 @@ | ||
|
||
$content .= "</tbody>\n</table>\n</div>\n"; | ||
} | ||
- } catch (\Exception $e) { | ||
+ } catch (\Error $e) { | ||
// something nasty happened and we cannot throw an exception anymore | ||
if ($this->debug) { | ||
$title = sprintf('Exception thrown when handling an exception (%s: %s)', \get_class($e), $this->escapeHtml($e->getMessage())); | ||
@@ -390,7 +390,7 @@ | ||
} else { | ||
try { | ||
$link = $fmt->format($path, $line); | ||
- } catch (\Exception $e) { | ||
+ } catch (\Error $e) { | ||
return sprintf('<span class="block trace-file-path">in <span title="%s%3$s"><strong>%s</strong>%s</span></span>', $this->escapeHtml($path), $file, 0 < $line ? ' line '.$line : ''); | ||
} | ||
} | ||
--- a/var/www/html/vendor/symfony/debug/Exception/FlattenException.php 2019-07-23 15:39:19.000000000 +0700 | ||
+++ b/var/www/html/vendor/symfony/debug/Exception/FlattenException.php 2021-09-27 15:09:06.000000000 +0700 | ||
@@ -33,7 +33,7 @@ | ||
private $file; | ||
private $line; | ||
|
||
- public static function create(\Exception $exception, $statusCode = null, array $headers = []) | ||
+ public static function create(\Error $exception, $statusCode = null, array $headers = []) | ||
{ | ||
$e = new static(); | ||
$e->setMessage($exception->getMessage()); | ||
@@ -59,7 +59,7 @@ | ||
|
||
$previous = $exception->getPrevious(); | ||
|
||
- if ($previous instanceof \Exception) { | ||
+ if ($previous instanceof \Error) { | ||
$e->setPrevious(static::create($previous)); | ||
} elseif ($previous instanceof \Throwable) { | ||
$e->setPrevious(static::create(new FatalThrowableError($previous))); | ||
@@ -178,7 +178,7 @@ | ||
return $this->trace; | ||
} | ||
|
||
- public function setTraceFromException(\Exception $exception) | ||
+ public function setTraceFromException(\Error $exception) | ||
{ | ||
$this->setTrace($exception->getTrace(), $exception->getFile(), $exception->getLine()); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.