Release 1.9.2 #1216
Merged
Release 1.9.2 #1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge staging into develop
* initial commit * add moment webpack plugin and min files * completely removed momentjs and replaced it with date-fns * changed firmat string and added parseISO function
* changed approach a little to ensure production image is being built for staging * corrected misplaced ARG line * moved the /wait back into the docker-compose.yml helps simplify the entrypoint and keeps the /wait command close to where its args are defined, i.e., `WAIT_HOSTS` env var. * removed unnecessary check * removed some copy-paste remnants
Add CSS overflow-x:hidden to prevent unnecessary horizontal scrollbar from appearing
In case the app is ever moved to a different cluster, having this script will make initialization much quicker for secrets.
* replace <input type="text"> with <textarea> for multiline edit * removed(commented)duplicate scss, add auto resize lib, fix e2e for textarea * add textarea auto resize lib, fix e2e for textarea, fix duplicate scss imports * remove unneeded package reference * remove unneeded package * Update .vscode/settings.json yes, always changing the terminal to the docker folder Co-authored-by: Christopher Hirt <chris@hirtfamily.net> * Update src/angular-app/languageforge/lexicon/editor/_editor.scss Co-authored-by: Christopher Hirt <chris@hirtfamily.net> * Update src/angular-app/languageforge/lexicon/lexicon.scss Co-authored-by: Christopher Hirt <chris@hirtfamily.net> * revert changes to docker .vscode * Added fork comment for angularjs-autogrow * removed angularjs-autogrow library added FixTextDirective directive * removed angularjs-autogrow library added FitTextDirective directive * Adding FitTextDirective class Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
This will ensure that lfmerge logs get sent to stdout whether or not sillsdev/LfMerge#134 is merged. Currently lfmerge runs in the lf-app container so its log messages end up mixed together with the PHP logs in `kubectl logs` output, but it's pretty easy to sort them out. If that mixing is not desired, then the entrypoint.sh changes can be reverted and `kubectl exec` can be used to run `tail -f /var/log/syslog` on the container instead.
This PR template is based off of https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ and customized for this project
Used the GH issue template wizard to generate these, and then customized from there.
Changed our sass dependency from a C based version to a Javascript based version to avoid x86/arm64 compatibility issues and requiring additional python dependencies for the ad-hoc build. Fixes #1137
Removing the checkboxes and keeping them as bullet points so that they don't show up as "tasks" in the PR card.
Requested change per #1148
Forced an x86 platform on our local dev processes so those Apple Silicon users can work on this project...with the current exception of running e2e test locally.
Two tests rely on wording from moment.js which has changed slightly in date-fns. This commit allows the new date-fns wording to be matched.
…o-shrinking (#1143) Added css styles and tweaks to remove excess whitespace. Adjusted FitTextDirective directive class to enable textarea more robust autosizing.
…#1160) Since I needed the ability to access the locally running app from my phone, I had to update some of proxy config to allow it.
When users log in or sign up, if they have a most-recently-used project or are a member of only one project, they are taken directly to that project instead of seeing the "My Projects" list. However, the "My Projects" breadcrumb and "List All Projects" menu entry still work and take users to the projects list, so that anyone who's used to using those links won't have to change habits.
When mobile users were trying to add data in the app, the device keyboard, e.g., Android keyboard, would pop up and already be in a "title-case" mode where the first letter would be capitalized but this is a bit cumbersome for users because he/she would have to go back to the word and lowercase the first letter. So this request is made to help us give the user's browser some hints that the user's keyboard should not "autocapitalize" for given fields or perhaps the keyboard should "all caps" for other fields. It's worth noting that this is not something the application can necessarily force upon the user's keyboard but hopefully these "hints" will be respected in many, if not all, cases.
* Add page-up page-down to editor component * narrowed window binding scope, added event listener unbind and destroy scope * remove this.$scope.$destroy(); from leaving page. not needed.
Fixes #1152 Add `-q` flag to the `sass` command to suppress all warning messages. The current deprecation warnings are related to our version of bootstrap, and we don't know how much work it would be to upgrade, so I decided the easiest thing to move forward is to silence those warnings.
users can't do anything about them, they tend to be very sporadic and have no bad side effects on the backend data.
This updates the last_login timestamp for OAuth logins. This fixes a bug where the last_login field is not updated for users who choose to login via Google or FB login. I also changed the name of the method to `doSilexLogin()` to make it more clear that this is a login success handler.
* remove site footer across application This removes the footer across all views in the app. We leave the footer in place for the brochure home page. Move the version string to be an image title on the logo. * adjust container height magic numbers maximum vertical space now that the footer is gone
The intent of reducing vertical padding/margin on edit controls is to increase the usable space in the editor which increases information density for the user. With this change, the user can see more fields in the entry, as well as see more entries in the compact list on the left side.
This will stop the lf-app logs from getting filled up with a constant stream of xdebug messages about not being able to connect.
Our Symfony version is old and was designed for PHP 5, where exceptions derived from the Exception base class. In PHP 7, exceptions derive from Error instead. Since upgrading our Symfony version is not feasible right now, we patch the installed version of Symfony to expect exceptions derived from Error. This ensures that the PHP error log will contain the actual exceptions thrown instead of "Expected Exception instance and got Error instance instead" errors that swallow the original exception.
This PR will update the UI for those users wanting to invite outsiders into a project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will release the updates referenced below as well as some additional engineering fixes.
How Has This Been Tested?
Ensured the site footer was absent, remove site footer across application #1198
Verified the editor view was more compact, reduce vertical padding/margin on form controls in edit view #1199
Verified the "Share" flow was simpler now, Simplify "Share with others" UX #1213
