Skip to content

Conversation

siltomato
Copy link
Collaborator

@siltomato siltomato commented Oct 1, 2025

This PR fixes an issue where the user lynx settings in the translator dialog weren't reacting to project settings changes. The component in general was reworked to no longer reference getters and setters in the component template.


This change is Reviewable

@siltomato siltomato added the will require testing PR should not be merged until testers confirm testing is complete label Oct 1, 2025
@siltomato siltomato changed the title SF-3588 fix translator dialog lynx master switch reactivity to project changes SF-3588 Fix translator dialog lynx master switch reactivity to project changes Oct 1, 2025
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.32%. Comparing base (3f79932) to head (c3cf244).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ate/editor/translator-settings-dialog.component.ts 90.69% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3486   +/-   ##
=======================================
  Coverage   82.31%   82.32%           
=======================================
  Files         613      613           
  Lines       36871    36879    +8     
  Branches     6048     6047    -1     
=======================================
+ Hits        30351    30360    +9     
- Misses       5627     5641   +14     
+ Partials      893      878   -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siltomato siltomato marked this pull request as ready for review October 1, 2025 18:09
@pmachapman pmachapman self-assigned this Oct 1, 2025
@pmachapman pmachapman self-requested a review October 1, 2025 18:25
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @siltomato)

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Oct 1, 2025
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Oct 3, 2025
@Nateowami Nateowami force-pushed the fix/sf-3588-lynx-settings-not-responding-when-changed-in-other-browser branch from 452ca7a to c3cf244 Compare October 3, 2025 14:52
@Nateowami Nateowami enabled auto-merge (squash) October 3, 2025 14:54
@Nateowami Nateowami merged commit f38ae20 into master Oct 3, 2025
21 checks passed
@Nateowami Nateowami deleted the fix/sf-3588-lynx-settings-not-responding-when-changed-in-other-browser branch October 3, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing complete Testing of PR is complete and should no longer hold up merging of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants