add bold and italic to surrounding pairs #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvenon
requested changes
Jul 25, 2018
There was a problem hiding this comment.
Hey, thanks! After making a minor adjustment specified below, you could also add this to the official Markdown language configuration because it doesn't have those.
language-configuration.json
Outdated
| ["`", "`"] | ||
| ["`", "`"], | ||
| ["_", "_"], | ||
| ["**", "**"] |
There was a problem hiding this comment.
Double asterisks won't work, change them into single asterisks. If you want to surround selected text with double asterisks, simply press the asterisk key twice. 😉
|
I changed the PR to use single asterisks 👍 |
nikolasburk
added a commit
to nikolasburk/vscode
that referenced
this pull request
Jul 25, 2018
Same reasons as [here](silvenon/vscode-mdx#6 (comment))
mjbvz
pushed a commit
to microsoft/vscode
that referenced
this pull request
Jul 26, 2018
Same reasons as [here](silvenon/vscode-mdx#6 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing markdown, I often have the situation that I want to make one word italic or bold. Currently I need to move the cursor to the beginning and end of the word and add the corresponding formatting (
_for italic,**for bold).It would be nice if I could just select the entire word and then apply the formatting once.
Note: I added this after I saw how the backticks were added previously. I am not sure if that actually works for the
**- if no I'm happy to update the PR. (Maybe there's some other way to get that kind of convenience though?)