Add mime-type lookup to Response.type(...) #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthomerson
commented
Feb 13, 2019
| @@ -0,0 +1,25 @@ | |||
| NOTE: The mime database in this folder (`standard.json`) was taken from | |||
| https://github.com/broofa/node-mime#readme, which is licensed with the following license. | |||
| The code written to read this file was written by us. | |||
There was a problem hiding this comment.
Note to reviewer: I did this to reduce the package size. The mime package, even though it doesn't have any dependencies, is fairly large because of the additional more full-featured database that it includes. Since it's those additional (rarely-used) types are unlikely to be needed, and we're trying to keep our @silvermine/lambda-express package size small, I just imported the "lite" database and wrote my own wrapper for it. The MIT licensing made this acceptable to do.
The documentation said it was supposed to do mime type lookup for you
(e.g. `type('.html') => 'text/html'`), but that was unimplemented.
Rather than add a dependency on the `mime` package, we have pulled in
the "lite" database used by that package. We did this to reduce the
package size. The `mime` package, even though it doesn't have any
dependencies, is fairly large because of the additional more
full-featured database that it includes. Since it's those additional
(rarely-used) types are unlikely to be needed, and we're trying to keep
our `@silvermine/lambda-express` package size small, we just imported
the "lite" database and wrote our own wrapper for it. The MIT licensing
made this acceptable to do.
jthomerson
force-pushed
the
response-mime-types
branch
from
1c1df25 to
c197a55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation said it was supposed to do mime type lookup for you
(e.g.
type('.html') => 'text/html'), but that was unimplemented.