Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW restored Extension::__construct() #7053

Conversation

fspringveldt
Copy link

Fixes #6965


public function __construct()
{
$this->class = get_class($this);
Copy link
Contributor

@tractorcow tractorcow Jun 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to add parent::__construct() to all the places it was removed, as well.

Also, we've removed the $class property; that shouldn't be re-introduced.

@fspringveldt fspringveldt force-pushed the pulls/4.0/restore-extension-constructor branch from 5bbcd51 to f8f6473 Compare June 25, 2017 22:48
@tractorcow
Copy link
Contributor

One linting bug @fspringveldt

FILE: ...build/silverstripe/silverstripe-framework/src/Core/Extension.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 50 | ERROR | [x] Function closing brace must go on the next line
    |       |     following the body; found 1 blank lines before
    |       |     brace
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

@fspringveldt fspringveldt force-pushed the pulls/4.0/restore-extension-constructor branch from f8f6473 to d3d426b Compare June 26, 2017 05:35
@tractorcow tractorcow merged commit 17c8e91 into silverstripe:master Jun 26, 2017
@fspringveldt fspringveldt deleted the pulls/4.0/restore-extension-constructor branch June 26, 2017 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants