Check array keys existence prior to their usage when removing methods #8707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very similar to #8703 |
|
I think in our case it would get past that added condition and still fail on checking unset array keys. |
michalkleiner
force-pushed
the
pulls/4/check-array-props-in-custom-methods
branch
from
f9311c9
to
91a2062
Compare
Correct links in 13_CSS_Coding_Conventions.md
- Enable viewing of draft assets - Disable viewing of .htaccess and .method - Enforce File.allowed_extensions (manually for now)
…dev mode [ci skip]
DOCS Update HTTP Cache headers docs to include note about testing in dev mode
…givimeo-a-relevant-lesson DOCS Updating "lesson 0" to a relevant link
Moved the guts to "making a core release", since it's only really relevant to that audience. There's more work to do around making security and non-security releases the same (less special handling), but I think this is a good start. [ci-skip]
…ding-your-module-doc Adding a Upgrade module guide
…legacy-filenames DOCS Clarify file migration and mention known bug
Update nginx example to support assets better
This lets us replace classes that extend certain other classes with a provided list of traits.
…-to-trait Add class to trait visitor.
Throw error message when searchable_field does not return a object
…3/strip-bom-on-csv-import FIX Byte Order Marks (BOM) are now stripped when importing CSV files
…ursive-writeComponent BUG Allow infinite loop when calling DataObject::writeComponent() recursively
…4/stream-ree-tags FIX Skip md5-ing the whole contents of a stream for etags
# Conflicts: # src/View/ThemeResourceLoader.php
Fixes regression in silverstripe@3d989a6.
…erstripe#9248) Allow non summary fields to be used as grid field export fields
…ix-file-permission Fix administrators not being able to see files that are restricted to groups
In some situations, a caption is used in place of a value in the alt attribute, and in others an image may be cosmetic and not in need of an alt attribute value (though the alt attribute must still be rendered in this case).
…verstripe#9257) FIX Add 'legal empty attributes' to allow empty alt values on imgs
A potential account hijacking may happen if an attacker has physical access to victim's computer to perform session fixation. Also possible if the targeted application contains an XSS vulnerability. Requires the victim to click the password reset link sent to their email. If all the above happens, attackers may reset the password before the actual user does that.
…ess through permission cache pollution
michalkleiner
force-pushed
the
pulls/4/check-array-props-in-custom-methods
branch
2 times, most recently
from
fee8392
to
9244730
Compare
… in CustomMethods
michalkleiner
force-pushed
the
pulls/4/check-array-props-in-custom-methods
branch
from
9244730
to
52a039f
Compare
…hods in CustomMethods
|
I think this PR needs a rebase |
|
Will look into it |
|
For a couple minutes I was super confused why there are no changes, but a newer PR #9271 has already been merged. |
michalkleiner
deleted the
pulls/4/check-array-props-in-custom-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated piece of code throws a Notice when trying to use the failover mechanism with a custom object other than the standard SiteTree via a ContentController.