FIX Calculate threshold condition with SQL rather than PHP #8921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScopeyNZ
force-pushed
the
pulls/4.3/threshold-count-in-sql
branch
from
81d3cc7
to
3b1c774
Compare
This is a performance fix. Modern SQL engines can avoid counting a whole result set (potentially thousands of records) when you are only interested if the count exceeds a threshold.
ScopeyNZ
force-pushed
the
pulls/4.3/threshold-count-in-sql
branch
from
3b1c774
to
a48beac
Compare
ScopeyNZ
commented
Apr 16, 2019
| static::$foreignListCache[$hasOneClass] = [ | ||
| 'count' => $list->count(), | ||
| 'overThreshold' => $overThreshold, |
There was a problem hiding this comment.
It's possible albeit incredibly unlikely that this is a breaking change if someone is relying on the existing count cache in a subclass.
There was a problem hiding this comment.
I'm not sure we'd consider that part of our API to be honest
robbieaverill
approved these changes
Apr 17, 2019
| static::$foreignListCache[$hasOneClass] = [ | ||
| 'count' => $list->count(), | ||
| 'overThreshold' => $overThreshold, |
There was a problem hiding this comment.
I'm not sure we'd consider that part of our API to be honest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a performance fix. Modern SQL engines can avoid counting a whole result set (potentially thousands of records) when you are only interested if the count exceeds a threshold.
Split from #8915. This is now targeting 4.3 as a patch. Happy to retarget any other branch if requested 🙂
I am setting this query to not be
DISTINCTwhich I think is an okay assumption. Feel free to close this PR if I'm wrong.