Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetching waterfall after retrying a NeXus vis #659

Merged
merged 1 commit into from
May 14, 2021
Merged

Fix fetching waterfall after retrying a NeXus vis #659

merged 1 commit into from
May 14, 2021

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented May 12, 2021

... by moving all prefetching out of useNxData and into NxValuesFetcher.

useNxData and all its sub-hooks become regular utilities, since they no longer need to retrieve the valuesStore from context.

@axelboc axelboc requested a review from loichuder May 12, 2021 14:16
@axelboc axelboc mentioned this pull request May 12, 2021
Open
4 tasks
loichuder
loichuder approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only auxDatasets to move around, great otherwise !

src/h5web/vis-packs/nexus/NxValuesFetcher.tsx Outdated Show resolved Hide resolved
src/h5web/vis-packs/nexus/utils.ts Show resolved Hide resolved
Base automatically changed from vis-container to main May 14, 2021 06:56
@axelboc axelboc merged commit ea1bd49 into main May 14, 2021
@axelboc axelboc deleted the prefetch branch May 14, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelboc @loichuder