Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Fixed numpy v2 deprecation warnings #4100

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Apr 4, 2024

Checklist:


Merge PR #4102 first!

This PR fixes deprecations warnings raised while testing silx with numpy 2 for PR #4082 (some of the deprecation warnings were also raised by numpy 1.26):

  • numpy.trapz renamed to trapezoid
  • numpy.cross no longer supports 2d-vector input
  • No longer possible to convert an array to a scalar (e.g., float(np.array([0])))

Closes #4097

@kif, @pierrepaleo please cautiously check the change in sift/alignment.

@t20100 t20100 added this to the 2.1.0 milestone Apr 4, 2024
@t20100 t20100 requested review from kif and pierrepaleo April 4, 2024 09:30
@t20100 t20100 force-pushed the fix-deprecation branch 2 times, most recently from 4514000 to 360dbd4 Compare April 11, 2024 08:56
@t20100
Copy link
Member Author

t20100 commented Apr 15, 2024

CI is broken due to some issues with PySide6.7, PR #4108 should workaround this by pinning PySide6 for now.

@t20100
Copy link
Member Author

t20100 commented Apr 17, 2024

Rebased in use fixes from PR #4108

@t20100
Copy link
Member Author

t20100 commented Apr 17, 2024

This is ready for review

@payno payno merged commit 4e1bd4e into silx-kit:main Apr 18, 2024
7 of 8 checks passed
@t20100 t20100 deleted the fix-deprecation branch July 11, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy 2 deprecation warnings
2 participants