-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
silx.io.open: Added basic support for tiled URLs #4121
Draft
t20100
wants to merge
13
commits into
silx-kit:main
Choose a base branch
from
t20100:tiled
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasole/pymca#1075 should deal with it |
Hello! I am just writing to provide a heartbeat...we're very interested in this work. We have recently had our time consumed with some urgent operational tasks, and NSLS-II heads back into operations next week. We look forward to digging into this. |
payno
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
<Module or Topic>: <Action> <Summary>
(see contributing guidelines)This PR adds minimal support for tiled in
silx.io.open
through asilx.io.tiledh5
module.As it stand, it only supports
Container
andArrayClient
.There is a way to limit the number of entries retrieved for each group by setting
silx.io.tiledh5.TiledH5.MAX_CHILDREN_PER_GROUP
(default: all).silx.io.open
tries to open http(s) URLs withh5pyd
andtiled
when available and raises anIOError
exception when both fail.Other exceptions when accessing content (timeout, connection errors) are not catched.
There a shortcut in
silx.io.open
added in first poc when passing an URL with atiled-
prefix that I would prefer to remove now that the basic URL can be used. (Note: since first poc in this branch, I changed the prefix fromtiled:
totiled-
to avoid issues with URL parsing) attn @vasoleRelated to #4106