Skip to content

fix: rewrite path resolution logic #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 9, 2018
Merged

fix: rewrite path resolution logic #21

merged 5 commits into from
Dec 9, 2018

Conversation

dpraul
Copy link
Contributor

@dpraul dpraul commented Oct 9, 2018

  • adds mocha & chai for unit-testing, run with yarn run test
  • path resolution pulled out to getFilePathFromUrl function
    • unit tests to prevent future regression
  • left in the logic wherein an invalid path is returned as "dummy", although this will cause problems if the served path contains a file named "dummy"

Fixes #15

@simonh1000
Copy link
Owner

wow -thanks - give me a few days (hopefully this weekend) to review

@simonh1000 simonh1000 self-requested a review October 20, 2018 11:26
@simonh1000
Copy link
Owner

Hi, apologies for being so slow. Will look at it but there's lots here I must learn (and can learn from) here. Could you merge in master?

@dpraul
Merge remote-tracking branch 'remotes/upstream/master' into fix/path-…
e048a56 
…traversal

# Conflicts:
#	README.md
#	angular-http-server.js
@simonh1000 simonh1000 merged commit d68eea9 into simonh1000:master Dec 9, 2018
@dpraul dpraul deleted the fix/path-traversal branch December 10, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonh1000 simonh1000 Awaiting requested review from simonh1000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpraul @simonh1000