Skip to content

Conversation

jlashner
Copy link
Contributor

Switches ocs-util to using jupyter lab instead of jupyter notebook.

Description

Migrates jupyter notebook configurations to jupyter lab.

Motivation and Context

Jupyter lab is a pretty big upgrade to jupyter notebook, and has been requested by Kenji, and is currently being used in the smurf-jupyter environment. Allows you to view other filetypes like images and csvs, run terminal sessions, and more.

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Unless I am preparing a release, I have opened this PR onto the develop branch.

@jlashner jlashner requested a review from BrianJKoopman April 15, 2021 21:02
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the switchover. I think we can drop jupyter from the requirements file, but correct me if I'm wrong.

@@ -1,4 +1,5 @@
jupyter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need jupyter? It doesn't look like a dependency to jupyterlab.

$ pip3 show jupyterlab
Name: jupyterlab
Version: 3.0.12
Summary: The JupyterLab server extension.
Home-page: http://jupyter.org
Author: Jupyter Development Team
Author-email: jupyter@googlegroups.com
License: BSD
Location: /home/koopman/.venv/jupyterlab/lib/python3.9/site-packages
Requires: jupyter-packaging, nbclassic, tornado, jupyter-server, jinja2, ipython, jupyter-core, jupyterlab-server, packaging
Required-by: 

@jlashner
Copy link
Contributor Author

Just tested and you're right, it works w/o the jupyter requirement

@BrianJKoopman BrianJKoopman self-requested a review April 16, 2021 14:33
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks again!

@BrianJKoopman BrianJKoopman merged commit a8824c2 into develop Apr 16, 2021
@BrianJKoopman BrianJKoopman deleted the ocs-util-jupyterlab branch April 16, 2021 14:34
@BrianJKoopman BrianJKoopman mentioned this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants