Remove spt3g/so3g dependency from the Registry #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing issues with the installation within the container, which cropped up when testing other changes. We shouldn't need the flag within the container anyway.
mhasself
approved these changes
Dec 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves
_enforce_field_name_rules()out of the Aggregator agent part of the ocs library and into theFeedclass, where similar field related static methods are. This eliminates the dependency of spt3g/so3g on the Registry Agent.Motivation and Context
Resolves #239
How Has This Been Tested?
The full test suite was run after the move. Also tested on a system without an spt3g/so3g installation (with
-m 'not spt3g') to verify that Registry tests no longer depend on spt3g/so3g.Types of changes
Checklist:
developbranch.