fix comparing of csv files with non-default file encoding #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonw - any thoughts on this? |
|
I would really like to have this feature merged in. The text Im comparing isnt always utf-8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the CLI to compare two CSVs that were encoded using cp1252 on a platform with a default encoding of utf-8, it fails. Since the encoding is not specified when opening the files, the default encoding is used and fails for any byte sequences that are not valid utf-8. This looks like it would resolve #14. The fix in this PR is to allow the user to specify the encoding of the file as a command line option.