Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jinja2 warnings #1338

Closed
simonw opened this issue May 24, 2021 · 0 comments
Closed

Fix jinja2 warnings #1338

simonw opened this issue May 24, 2021 · 0 comments
Labels
minor Minor bugs (not high priority)

Comments

@simonw
Copy link
Owner

simonw commented May 24, 2021

Lots of these in the test suite now, after the Jinja upgrade in #1331:

tests/test_plugins.py::test_hook_render_cell_link_from_json
  datasette/tests/plugins/my_plugin_2.py:45: DeprecationWarning: 'jinja2.escape' is deprecated and will be removed in Jinja 3.1. Import 'markupsafe.escape' instead.
    label=jinja2.escape(data["label"] or "") or " ",

tests/test_plugins.py::test_hook_render_cell_link_from_json
  datasette/tests/plugins/my_plugin_2.py:41: DeprecationWarning: 'jinja2.Markup' is deprecated and will be removed in Jinja 3.1. Import 'markupsafe.Markup' instead.
    return jinja2.Markup(
@simonw simonw added the minor Minor bugs (not high priority) label May 24, 2021
@simonw simonw closed this as completed in 2bd9d54 May 24, 2021
simonw added a commit that referenced this issue May 24, 2021
@simonw
Fix Jinja warnings, closes #1338, refs #1331
a0234fc
simonw added a commit that referenced this issue May 24, 2021
@simonw
Fixed another Jinja warning, refs #1338
eae3084
simonw added a commit that referenced this issue May 27, 2021
@simonw
Fixed another Jinja warning, refs #1338
78d9594
simonw added a commit that referenced this issue May 27, 2021
@simonw
Release 0.57a1
7b106e1 
Refs #1319, #1320, #1331, #1337, #1338, #1341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor Minor bugs (not high priority)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw