Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Em 1d funcs #27

Merged
merged 8 commits into from
Jun 25, 2021
Merged

Em 1d funcs #27

merged 8 commits into from
Jun 25, 2021

Conversation

jcapriot
Copy link
Member

This adds several analytic functions for specialized source - receiver orientations in for the frequency and time domain half-space responses.

These are mostly ported from em1d and simpeg, to live here.

(also updates horizontal components of time varying vertical magnetic dipole to be more stable)
(remove 0 time for radial components, it's too unstable at early times)
(add late time asymptotic tests)
@rowanc1
Copy link
Member

rowanc1 commented Jun 25, 2021

Super cool to see geoana getting some love!

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #27 (d3777ea) into main (e2077f1) will increase coverage by 1.90%.
The diff coverage is 84.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   66.84%   68.75%   +1.90%     
==========================================
  Files          16       21       +5     
  Lines         956     1040      +84     
==========================================
+ Hits          639      715      +76     
- Misses        317      325       +8     
Impacted Files Coverage Δ
geoana/em/tdem/wholespace.py 34.28% <42.85%> (ø)
geoana/em/tdem/halfspace.py 52.94% <52.94%> (ø)
geoana/em/tdem/base.py 75.00% <75.00%> (ø)
geoana/em/fdem/base.py 82.92% <80.00%> (-1.93%) ⬇️
geoana/__init__.py 100.00% <100.00%> (ø)
geoana/em/base.py 100.00% <100.00%> (ø)
geoana/em/fdem/__init__.py 100.00% <100.00%> (ø)
geoana/em/fdem/halfspace.py 89.79% <100.00%> (ø)
geoana/em/fdem/simple_functions.py 100.00% <100.00%> (ø)
geoana/em/static.py 92.03% <100.00%> (+0.73%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2077f1...d3777ea. Read the comment docs.

@jcapriot
Copy link
Member Author

Ya! Ideally I'd love to get all of the analytic functions that are randomly defined in SimPEG in here. It's a great home for them.
Plus, we can potentially provide some compiled items here as well (but also provide native python versions too).

@jcapriot jcapriot merged commit 6963407 into main Jun 25, 2021
@jcapriot jcapriot deleted the em_1d_funcs branch June 25, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants