Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref/em and docs #9

Merged
merged 21 commits into from
Jun 28, 2018
Merged

Ref/em and docs #9

merged 21 commits into from
Jun 28, 2018

Conversation

lheagy
Copy link
Member

@lheagy lheagy commented Jun 7, 2018

Magnetostatic Vector Potentials

  • add vector potentials for a dipole and loop source in geoana.em.static
  • add example for usage
  • associated testing
    image

Repo Maintenance

  • improve README, existing docs
  • test using anaconda installation
  • update gitignore
  • add sphinx gallery for docs
    image

lheagy added 20 commits June 2, 2018 14:21
@lheagy
add sphinx gallery to the docs, improve the readme, update the licens…
188b175 
…e to include 2018
@lheagy
add ipynb to gitignore
cb79ad9
@lheagy
docs for spatial, simplify how the cylindrical coordinate case is han…
9af6794 
…dled for the vector potential for the dipole
@lheagy
more cleanup of docstrings in geoana
1c77492
@lheagy
add conversions from spherical coordinates, include a page in the doc…
993f5e9 
…s about conventions
@lheagy
add tests for 3D tensor and cylindrical meshes
69ccd91
@lheagy
use branch of discretize with 3D cyl mesh
5e62f28
@lheagy
clean up docs
fc72b1a
@lheagy
update travis - use anaconda
566caa9
@lheagy
pip install requirements
93779a0
@lheagy
test edge cases where r=0, fix singularity when r=0
8ca1977
@lheagy
follow previous implementation for circular loop vector potential
bf530aa
@lheagy
follow current SimPEG implementation for circular loop
719c32d
@lheagy
cleanup static docstrings
2e76f68
@lheagy
more docstring cleanup
a132672
@lheagy
cleanup links in docs
a484308
@lheagy
more docs cleanup
423afba
@lheagy
more docs cleanup
df896cc
@lheagy
add an example for working with the vector potentials
6b5a15f
@lheagy
widen figure
160a7e5
@lheagy lheagy requested a review from sgkang June 7, 2018 05:40
@lheagy
Copy link
Member Author

lheagy commented Jun 7, 2018

@sgkang: would you mind taking a look at this?

lheagy
lheagy commented Jun 25, 2018
View reviewed changes
tests/test_em_static.py
self.assertTrue(loop_passed)
self.assertTrue(dipole_passed)

def test_magnetic_field_3Dcyl(self):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgkang: this is where the 3D cyl code is being tested

@lheagy
Copy link
Member Author

lheagy commented Jun 27, 2018

Thanks @sgkang: is this then good to go?

This was referenced Jun 27, 2018
Closed
Merged
@sgkang sgkang merged commit e226b5b into master Jun 28, 2018
@lheagy lheagy deleted the ref/em_and_docs branch June 28, 2018 19:50
@lheagy lheagy mentioned this pull request Jun 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgkang sgkang Awaiting requested review from sgkang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lheagy @sgkang