Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sidekiq #10045

Merged
merged 11 commits into from
Feb 12, 2024
Merged

Add Sidekiq #10045

merged 11 commits into from
Feb 12, 2024

Conversation

RiteshK-611
Copy link
Contributor

@RiteshK-611 RiteshK-611 commented Dec 7, 2023 •
edited by adamrusted
Loading

Issue: closes #9886

Similarweb rank:
Sidekiq has almost 13k stars in GitHub see https://github.com/sidekiq/sidekiq

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

This commit resolves the issue #9886 by adding svg/icon for Sidekiq

Preview

image

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 7, 2023
@RiteshK-611
Copy link
Contributor Author

RiteshK-611 commented Dec 7, 2023 •
edited
Loading

Hi @adamrusted
I think tried everything from my side but this lint is failing on Github

we can see here locally lint is passing and I even ran formatter
image

@RiteshK-611
Copy link
Contributor Author

also, now I updated all the 13 files with main develop branch and still my getting the error

@adamrusted
Copy link
Member

Hey @RiteshK-611 - have you recently run an npm install on our project? The only other thing I can think is that your editor's built in formatter is overriding our preferences. I've had this before where a local installation of ESLint was overriding our Prettier formatting.

@PeterShaggyNoble PeterShaggyNoble added the assessing Issues or icons that require manual input from a project maintainer before work can begin label Dec 8, 2023
@RiteshK-611
Copy link
Contributor Author

No, I haven't run npm install recently. Should I try running that?

@adamrusted adamrusted changed the title Add sidekiq svg Add Sidekiq Dec 14, 2023
PeterShaggyNoble
PeterShaggyNoble requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to include the background circle here, @RiteshK-611; all the monochrome versions at the source URL include it.

@PeterShaggyNoble PeterShaggyNoble removed the assessing Issues or icons that require manual input from a project maintainer before work can begin label Jan 11, 2024
@adamrusted adamrusted added the abandoned Pull requests that have been abandoned by the contributor label Feb 7, 2024
@adamrusted adamrusted removed the abandoned Pull requests that have been abandoned by the contributor label Feb 8, 2024
@PeterShaggyNoble PeterShaggyNoble merged commit 766ff6f into simple-icons:develop Feb 12, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Feb 18, 2024
Merged
mondeja added a commit that referenced this pull request Feb 18, 2024
@mondeja
Release 21 new icons and 2 updated icons (v11.5.0)
b922c7d 
# New Icons

- AnkerMake (#10465) (@adamrusted)
- Apache FreeMarker (#9471) (@PratyushJayachandran)
- Camunda (#10455) (@Mvlprem)
- Hevy (#10434) (@patrik-csak)
- Lucid (#10437) (@Garbg)
- Milanote (#10481) (@durgeshgowdac)
- NameMC (#10433) (@Garbg)
- Netdata (#10438) (@BenHur28)
- Papers With Code (#10435) (@Mvlprem)
- Photon (#10460) (@Mvlprem)
- PyCQA (#9994) (@adamrusted)
- QNAP (#10309) (@PeterShaggyNoble)
- radarr (#10443) (@21st-centuryman)
- Sidekiq (#10045) (@RiteshK-611)
- sonarr (#10444) (@21st-centuryman)
- Teal (#10470) (@Mvlprem)
- The Boring Company (#10457) (@PeterShaggyNoble)
- Typer (#10447) (@Mvlprem)
- vivo (#10129) (@LitoMore)
- Wikimedia Foundation (#10061) (@songnguxyz)
- Zaim (#10432) (@Garbg)

# Updated Icons

- Airbus (#10421) (@Garbg)
- Next.js (#7921) (@sisp)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Sidekiq logo
3 participants
@RiteshK-611 @adamrusted @PeterShaggyNoble