Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Apache Freemarker #9471

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Add Apache Freemarker #9471

merged 6 commits into from
Feb 15, 2024

Conversation

PratyushJayachandran
Copy link
Member

@PratyushJayachandran PratyushJayachandran commented Sep 1, 2023 •
edited
Loading

apachefreemarker

Issue: closes #9470

Similarweb rank: Not sure

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG: Taken from https://www.apache.org/logos but modified to look like the favicon on https://freemarker.apache.org
I overlaid the SVG on top and tried to match it the best I can.
Color: Taken from logo #326CAC

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 1, 2023
@service-paradis service-paradis added the pending Issues that are pending because of e.g. a scheduled brand update label Sep 1, 2023
@adamrusted
Copy link
Member

@service-paradis - why did you mark this one as pending? Is there an ongoing discussion?

@PratyushJayachandran
Copy link
Member Author

@service-paradis - why did you mark this one as pending? Is there an ongoing discussion?

Discussion on #9470

@PeterShaggyNoble
Copy link
Member

@PratyushJayachandran, do they use this icon anywhere else other than for their website's favicon?

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Nov 24, 2023
@PeterShaggyNoble PeterShaggyNoble removed the pending Issues that are pending because of e.g. a scheduled brand update label Dec 14, 2023
@adamrusted
Copy link
Member

To answer your question @PeterShaggyNoble - they use <F> as their Twitter icon, but otherwise it's the full wordmark. I'd say given how we've handled other Apache projects we should probably use the apache.org/logos variant as our 'source of truth'.

PeterShaggyNoble
PeterShaggyNoble previously requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PratyushJayachandran, could you update to use the full logo, please?

@PeterShaggyNoble PeterShaggyNoble removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jan 11, 2024
@PratyushJayachandran
Copy link
Member Author

@PratyushJayachandran, could you update to use the full logo, please?

I am awaiting some response on this one from freemarker. I will update as soon as I get that.

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jan 12, 2024
@adamrusted adamrusted removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Feb 8, 2024
@adamrusted
Copy link
Member

Following (albeit inconclusive) feedback from Freemarker team granting us permission to include the icon, I suggest we stick to our guns on using the Apache Logos source - and whatever is available there. Would you mind taking another look please @PratyushJayachandran?

@PratyushJayachandran
Copy link
Member Author

apachefreemarker2
Updated

@adamrusted adamrusted removed the request for review from PeterShaggyNoble February 15, 2024 09:38
@adamrusted adamrusted merged commit 0233685 into simple-icons:develop Feb 15, 2024
3 checks passed
@PratyushJayachandran PratyushJayachandran deleted the Add-Freemarker branch February 15, 2024 18:03
@github-actions github-actions bot mentioned this pull request Feb 18, 2024
Merged
mondeja added a commit that referenced this pull request Feb 18, 2024
@mondeja
Release 21 new icons and 2 updated icons (v11.5.0)
b922c7d 
# New Icons

- AnkerMake (#10465) (@adamrusted)
- Apache FreeMarker (#9471) (@PratyushJayachandran)
- Camunda (#10455) (@Mvlprem)
- Hevy (#10434) (@patrik-csak)
- Lucid (#10437) (@Garbg)
- Milanote (#10481) (@durgeshgowdac)
- NameMC (#10433) (@Garbg)
- Netdata (#10438) (@BenHur28)
- Papers With Code (#10435) (@Mvlprem)
- Photon (#10460) (@Mvlprem)
- PyCQA (#9994) (@adamrusted)
- QNAP (#10309) (@PeterShaggyNoble)
- radarr (#10443) (@21st-centuryman)
- Sidekiq (#10045) (@RiteshK-611)
- sonarr (#10444) (@21st-centuryman)
- Teal (#10470) (@Mvlprem)
- The Boring Company (#10457) (@PeterShaggyNoble)
- Typer (#10447) (@Mvlprem)
- vivo (#10129) (@LitoMore)
- Wikimedia Foundation (#10061) (@songnguxyz)
- Zaim (#10432) (@Garbg)

# Updated Icons

- Airbus (#10421) (@Garbg)
- Next.js (#7921) (@sisp)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble left review comments

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Apache Freemarker
4 participants
@PratyushJayachandran @adamrusted @PeterShaggyNoble @service-paradis