Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wikimedia Foundation #10061

Merged
merged 18 commits into from
Feb 12, 2024
Merged

Add Wikimedia Foundation #10061

merged 18 commits into from
Feb 12, 2024

Conversation

songnguxyz
Copy link
Contributor

@songnguxyz songnguxyz commented Dec 11, 2023 •
edited by adamrusted
Loading

image

Issue: closes #9684

Similarweb rank: see issue

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Everything has already been mentioned in the issue, thanks Peter for helps.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 11, 2023
@songnguxyz
Update simple-icons.json
ffbfc7d 
it has to be CC0
@songnguxyz

This comment was marked as resolved.

Sign in to view
@songnguxyz

This comment was marked as resolved.

Sign in to view
PeterShaggyNoble
PeterShaggyNoble requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @pisceskaze 👍🏻 However, I'm seeing some differences in the outer circle between your version (in red) and the source (in black). This could either be as a result of converting the stroke to a path, or gettinng the intersection with the clip-path. When I tried it myself, both created differences for me, too - although, different differences to yours.

_data/simple-icons.json Outdated Show resolved Hide resolved
songnguxyz and others added 2 commits December 11, 2023 23:29
@songnguxyz
I hate that line
b929fff
@songnguxyz @PeterShaggyNoble
Update _data/simple-icons.json
440e845 
Ok-

Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
@songnguxyz
Copy link
Contributor Author

songnguxyz commented Dec 11, 2023 •
edited
Loading

Thanks for the contribution, @pisceskaze 👍🏻 However, I'm seeing some differences in the outer circle between your version (in red) and the source (in black). This could either be as a result of converting the stroke to a path, or gettinng the intersection with the clip-path. When I tried it myself, both created differences for me, too - although, different differences to yours.

Seems like it to me, it's hard to be noticed without a direct check. I used Boxy SVG for that exactly.

@adamrusted adamrusted changed the title Request: Wikimedia Foundation Add Wikimedia Foundation Dec 14, 2023
@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @songnguxyz?

@adamrusted adamrusted added the abandoned Pull requests that have been abandoned by the contributor label Feb 4, 2024
@adamrusted adamrusted removed the abandoned Pull requests that have been abandoned by the contributor label Feb 8, 2024
@PeterShaggyNoble PeterShaggyNoble merged commit e2b22e4 into simple-icons:develop Feb 12, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Feb 18, 2024
Merged
mondeja added a commit that referenced this pull request Feb 18, 2024
@mondeja
Release 21 new icons and 2 updated icons (v11.5.0)
b922c7d 
# New Icons

- AnkerMake (#10465) (@adamrusted)
- Apache FreeMarker (#9471) (@PratyushJayachandran)
- Camunda (#10455) (@Mvlprem)
- Hevy (#10434) (@patrik-csak)
- Lucid (#10437) (@Garbg)
- Milanote (#10481) (@durgeshgowdac)
- NameMC (#10433) (@Garbg)
- Netdata (#10438) (@BenHur28)
- Papers With Code (#10435) (@Mvlprem)
- Photon (#10460) (@Mvlprem)
- PyCQA (#9994) (@adamrusted)
- QNAP (#10309) (@PeterShaggyNoble)
- radarr (#10443) (@21st-centuryman)
- Sidekiq (#10045) (@RiteshK-611)
- sonarr (#10444) (@21st-centuryman)
- Teal (#10470) (@Mvlprem)
- The Boring Company (#10457) (@PeterShaggyNoble)
- Typer (#10447) (@Mvlprem)
- vivo (#10129) (@LitoMore)
- Wikimedia Foundation (#10061) (@songnguxyz)
- Zaim (#10432) (@Garbg)

# Updated Icons

- Airbus (#10421) (@Garbg)
- Next.js (#7921) (@sisp)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble approved these changes

@service-paradis service-paradis Awaiting requested review from service-paradis

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wikimedia Foundation
3 participants
@songnguxyz @PeterShaggyNoble @adamrusted