Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NameMC icon #10433

Merged
merged 5 commits into from
Feb 11, 2024
Merged

Add NameMC icon #10433

merged 5 commits into from
Feb 11, 2024

Conversation

Garbg
Copy link
Contributor

@Garbg Garbg commented Feb 10, 2024

namemc

Issue: closes #10410

Similarweb rank:
Global: 5931
Country (US): 8275
Category: 73

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I manually vectorized the icon because it was simple pixel art and an automatic vectorization would probably have been less accurate. The logo is updated now.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Feb 10, 2024
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd be better including the square to be honest. I've also generated the below preview using the background colour of the website. What do you think @Garbg?
image

As far as manual recreation goes, I've generated the below path on a 30x30px grid (same size as the favicon) and then shrunk down to meet our canvas size. You're welcome to use it - we'll need another maintainer to review if you do!

M24,0L24,24L0,24L0,0L24,0ZM16,8L16,4.8L4.8,4.8L4.8,19.2L8,19.2L8,8L16,8ZM16,8L16,19.2L19.2,19.2L19.2,8L16,8Z

@Garbg
Copy link
Contributor Author

Garbg commented Feb 11, 2024

I'll update the icon when I can

@Garbg
Copy link
Contributor Author

Garbg commented Feb 11, 2024

I'll only have 1 square of outline (which means each square is 4 pixels)

@Garbg
Copy link
Contributor Author

Garbg commented Feb 11, 2024

The favicon has 2 squares of outline, but the logo on the navbar only has 1 so I'll go with one square of outline

@adamrusted
Copy link
Member

adamrusted commented Feb 11, 2024

The one I used was the logo from the navbar and that's got 2 pixels around the shape. Worth basing off of this one if possible - given that's the main one they show.

@Garbg
Copy link
Contributor Author

Garbg commented Feb 11, 2024

The requested changes have been done.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing some differences when comparing to the path I created by doing a 1:1 trace at 30x30px - and then shrinking down.

@Garbg
Copy link
Contributor Author

Garbg commented Feb 11, 2024

I opened the image in a pixel art editor to see the sizes of everything, so I'll recreate it in vector then scale it down from 30x30 to 24x24

@Garbg
Copy link
Contributor Author

Garbg commented Feb 11, 2024

I updated the icon again

@adamrusted adamrusted added the vector unavailable Issues and Pull Requests where no official SVG is available. label Feb 11, 2024
@adamrusted adamrusted merged commit 8e239cd into simple-icons:develop Feb 11, 2024
3 checks passed
@Garbg Garbg deleted the namemc branch February 11, 2024 21:12
mondeja added a commit that referenced this pull request Feb 18, 2024
# New Icons

- AnkerMake (#10465) (@adamrusted)
- Apache FreeMarker (#9471) (@PratyushJayachandran)
- Camunda (#10455) (@Mvlprem)
- Hevy (#10434) (@patrik-csak)
- Lucid (#10437) (@Garbg)
- Milanote (#10481) (@durgeshgowdac)
- NameMC (#10433) (@Garbg)
- Netdata (#10438) (@BenHur28)
- Papers With Code (#10435) (@Mvlprem)
- Photon (#10460) (@Mvlprem)
- PyCQA (#9994) (@adamrusted)
- QNAP (#10309) (@PeterShaggyNoble)
- radarr (#10443) (@21st-centuryman)
- Sidekiq (#10045) (@RiteshK-611)
- sonarr (#10444) (@21st-centuryman)
- Teal (#10470) (@Mvlprem)
- The Boring Company (#10457) (@PeterShaggyNoble)
- Typer (#10447) (@Mvlprem)
- vivo (#10129) (@LitoMore)
- Wikimedia Foundation (#10061) (@songnguxyz)
- Zaim (#10432) (@Garbg)

# Updated Icons

- Airbus (#10421) (@Garbg)
- Next.js (#7921) (@sisp)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon vector unavailable Issues and Pull Requests where no official SVG is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: NameMC
2 participants