Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Next.js icon and data #7921

Merged
merged 10 commits into from Feb 13, 2024

Conversation

sisp
Copy link
Contributor

@sisp sisp commented Oct 5, 2022

image

Issue: closes #7742, closes #7626

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The new Next.js wordmark uses gradient transitions which cannot be converted to a monochromatic icon. We've discussed in #7742 that it might be better to use the full wordmark instead. I've also updated the guidelines link as suggested in #7626.

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Oct 5, 2022
@LitoMore
Copy link
Member

LitoMore commented Oct 5, 2022

I'd prefer just N.

Next.js is using the logo on their main project. The full trademark looks not good on a badge.

See https://github.com/vercel/next.js/blob/canary/packages/next/README.md?plain=1#L22

@sisp
Copy link
Contributor Author

sisp commented Oct 5, 2022

But what do we do about the gradient transition?

@LitoMore
Copy link
Member

LitoMore commented Oct 5, 2022

Let's ask Next.js for help. Just let them know Simple Icons does not support gradient colors.

It would be good if they can design a specific version for Simple Icons.

@sisp
Copy link
Contributor Author

sisp commented Oct 5, 2022

I've started a discussion over at Next.js: vercel/next.js#41193

@sisp sisp marked this pull request as draft October 5, 2022 15:52
@service-paradis service-paradis added the pending Issues that are pending because of e.g. a scheduled brand update label Jul 12, 2023
@adamrusted
Copy link
Member

Hey @ijjk - is there currently a monochrome (including without the gradient) version of the NextJS N icon? If we're able to use it here - any chance you can share somewhere it's publicly available?

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jul 18, 2023
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVG itself is a perfect match, if we go ahead with the full wordmark until Next update their icon format. Just a quick change to the JSON, seems they've updated URLs since this PR was put in. Once that's done, let's get this merged in!

_data/simple-icons.json Outdated Show resolved Hide resolved
@adamrusted adamrusted added changes requested and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Sep 8, 2023
@LitoMore
Copy link
Member

LitoMore commented Sep 8, 2023

I want to keep their icon visual at https://github.com/vercel/next.js.

BTW, the Next.js Conf will be back in October. They should revise the logo again.

@adamrusted
Copy link
Member

I want to keep their icon visual at https://github.com/vercel/next.js.

Oh I totally agree, but in the absence of an official monochrome treatment for the 'new' icon - we should go with a safe monochrome treatment from the brand. Let's hold fire until Next Conf, and if there's no significant re-brand I'd look to merge this one in.

@PratyushJayachandran
Copy link
Member

I want to keep their icon visual at https://github.com/vercel/next.js.

Oh I totally agree, but in the absence of an official monochrome treatment for the 'new' icon - we should go with a safe monochrome treatment from the brand. Let's hold fire until Next Conf, and if there's no significant re-brand I'd look to merge this one in.

So I was looking their Readme and saw them using Next.js icon hosted in simple-icons.
It is the same as their favicon on https://nextjs.org/
So why are we changing it to wordmark?

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still no official monochrome treatment from what I can see. We can either proceed with the wordmark, as that's the only monochrome treatment offered by the brand at this time - or we adapt their currently used icon (as I imagine we had to do with the old version too!)

@PeterShaggyNoble
Copy link
Member

I vote to give the icon our own treatment. But, then, I'll always vote in favour of an icon over a wordmark!

@PeterShaggyNoble
Copy link
Member

So, @simple-icons/maintainers, where have we landed on this?

@service-paradis
Copy link
Member

They have a monochrome version of their favicon buried in their Github:
https://github.com/vercel/next.js/blob/6b3d145e7e7e88037f4e326cc63038814ab5fd76/examples/cms-prepr/public/favicon/safari-pinned-tab.svg?plain=1#L4

So, I think we're safe!

@adamrusted
Copy link
Member

adamrusted commented Dec 14, 2023

@service-paradis - that looks to be the old version of the icon, note the last commit was 2yrs ago.
The new one is a much chunkier font.

@service-paradis
Copy link
Member

Hum... yeah, you're right...

@PeterShaggyNoble
Copy link
Member

It's been well over a year since Lito started the discussion in their repo and there's been no response so I think it's time we make an executive decision. Consensus seems to be that we use the icon rather than the wordmark so could you update the PR accordingly, @sisp? The best option is probably just to use the same treatment as for our existing icon.

@PeterShaggyNoble PeterShaggyNoble removed the pending Issues that are pending because of e.g. a scheduled brand update label Jan 11, 2024
@adamrusted adamrusted marked this pull request as ready for review February 8, 2024 19:18
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the diagonal of the "N" should still touch the edge of the circle here, @adamrusted.

icons/nextdotjs.svg Outdated Show resolved Hide resolved
@PeterShaggyNoble PeterShaggyNoble merged commit 6ea9e7b into simple-icons:develop Feb 13, 2024
3 checks passed
mondeja added a commit that referenced this pull request Feb 18, 2024
# New Icons

- AnkerMake (#10465) (@adamrusted)
- Apache FreeMarker (#9471) (@PratyushJayachandran)
- Camunda (#10455) (@Mvlprem)
- Hevy (#10434) (@patrik-csak)
- Lucid (#10437) (@Garbg)
- Milanote (#10481) (@durgeshgowdac)
- NameMC (#10433) (@Garbg)
- Netdata (#10438) (@BenHur28)
- Papers With Code (#10435) (@Mvlprem)
- Photon (#10460) (@Mvlprem)
- PyCQA (#9994) (@adamrusted)
- QNAP (#10309) (@PeterShaggyNoble)
- radarr (#10443) (@21st-centuryman)
- Sidekiq (#10045) (@RiteshK-611)
- sonarr (#10444) (@21st-centuryman)
- Teal (#10470) (@Mvlprem)
- The Boring Company (#10457) (@PeterShaggyNoble)
- Typer (#10447) (@Mvlprem)
- vivo (#10129) (@LitoMore)
- Wikimedia Foundation (#10061) (@songnguxyz)
- Zaim (#10432) (@Garbg)

# Updated Icons

- Airbus (#10421) (@Garbg)
- Next.js (#7921) (@sisp)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Next.js icon [Next.js] No brand guidelines
6 participants