Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hp icon #1759

Merged
merged 4 commits into from Oct 13, 2019
Merged

Add hp icon #1759

merged 4 commits into from Oct 13, 2019

Conversation

dennib
Copy link
Contributor

@dennib dennib commented Oct 12, 2019

Issue:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Manually vectorized the icon using hp.com as source.

@dennib dennib mentioned this pull request Oct 12, 2019
@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Oct 12, 2019
@birjj
Copy link
Contributor

birjj commented Oct 13, 2019

Thank you very much for your PR! The vectorization looks good, especially if you only had the small logo from their header to work off of. I do have a few things to mention tho:

  • Very minor detail, but it looks like they use the color #0096D6 instead of #0099D8, according to their CSS. We prefer using the official version where possible, even if the difference isn't exactly visible to the naked eye.
  • HP have a high-res version of their logo here. If we compare this to your vectorization, we unfortunately see that the vector is a bit off (in the below gif the vector is red, the official version is blue).

If you want to save yourself the trouble of vectorizing it all over again, we generally accept Wikimedia as a reliable source if no official vector exists - and in this case their HP logo vector seems to match the official version pretty well. It would simply have to be resized and annotated.

Thank you for the PR though! We really do appreciate the work that goes into it.

@dennib
Copy link
Contributor Author

dennib commented Oct 13, 2019

Thanks @birjolaxew!

I will work on the wikimedia version as soon as possible :)

@ericcornelissen ericcornelissen merged commit 230e258 into simple-icons:develop Oct 13, 2019
@ericcornelissen
Copy link
Contributor

Thanks for your work on this @dennib 🎉 Again, it is much appreciated 😄

ericcornelissen added a commit that referenced this pull request Oct 23, 2019
# New icons

- LibreOffice (#1763)
- IBM (#1768)
- Apache Airflow (#1766)
- Cisco (#1769)
- Epson (#1770)
- HP (#1759)
- CentOS (#1764)
- Minetest (#1751)
- Genius (#1777)
- Lenovo (#1772)
- iDEAL (#1778)
- Plesk (#1781)
- Bancontact (#1779)
- Krita (#1775)
- XRP (#1783)
- Ripple (#1784)
- SVG (#1790)
- Nec (#1796)
- Nim (#1776)
- Habr (#1804)
- Symantec (#1797)
- Analogue (#1802)
- AdGuard (#1810)
- Strapi (#1787)
- GIMP (#1813)
- uBlock Origin (#1815)

# Updated icons

- Apple Podcasts (#1803 and #1805)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants