Add Bancontact icon #1779
Merged
Add Bancontact icon #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looking good overall @Paulsky, I agree that blue is their preferred brand colour (looking at their website).
I think it would be better to remove the "Bancontact" text from the logo though 🤔 Although it is not listed like that on the brand page, it is what they use as their favicon... @simple-icons/maintainers what do you think?
|
I agree with @ericcornelissen about removing the text from the icon @Paulsky to match the favicon. |
|
@ericcornelissen and @phatbhoy67 Understood. I just removed the text. What is your opinion about the new version? |
ericcornelissen
approved these changes
Oct 18, 2019
|
Looking good now @Paulsky, thanks a lot for your contribution! 😄 |
|
Thank you @ericcornelissen 🙏😄 |
ericcornelissen
added a commit
that referenced
this pull request
Oct 23, 2019
# New icons - LibreOffice (#1763) - IBM (#1768) - Apache Airflow (#1766) - Cisco (#1769) - Epson (#1770) - HP (#1759) - CentOS (#1764) - Minetest (#1751) - Genius (#1777) - Lenovo (#1772) - iDEAL (#1778) - Plesk (#1781) - Bancontact (#1779) - Krita (#1775) - XRP (#1783) - Ripple (#1784) - SVG (#1790) - Nec (#1796) - Nim (#1776) - Habr (#1804) - Symantec (#1797) - Analogue (#1802) - AdGuard (#1810) - Strapi (#1787) - GIMP (#1813) - uBlock Origin (#1815) # Updated icons - Apple Podcasts (#1803 and #1805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1747
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Because it's the first color mentioned here: https://www.bancontact.com/en/promotion-material/guidelines-logo
No, I downloaded it from https://www.bancontact.com/en/promotion-material/guidelines-logo
No