Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lenovo icon #1772

Merged
merged 4 commits into from Oct 17, 2019
Merged

Add Lenovo icon #1772

merged 4 commits into from Oct 17, 2019

Conversation

dennib
Copy link
Contributor

@dennib dennib commented Oct 13, 2019

Issue:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Added Lenovo icon from Wikimedia, a bit uncertain about the correct HEX color, I used the one found here: Scheme Color

@dennib dennib mentioned this pull request Oct 13, 2019
@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Oct 13, 2019
birjj
birjj previously requested changes Oct 13, 2019
Copy link
Contributor

@birjj birjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!

After a bit of googling I found that they actually have a page for their logo downloads that we would probably prefer to use as a source. They also have a visual identity guide, which tells us that the official "Lenovo red" color is #E2231A.

Could you please update the color and source to the above? I unfortunately won't be able to merge this week due to being on vacation, so I'll let @ericcornelissen check if the logo matches the official version. Nonetheless, thanks for the work you've put in already!

@dennib
Copy link
Contributor Author

dennib commented Oct 14, 2019

Totally missed that page, sure, I'll work on this soon

@dennib
Copy link
Contributor Author

dennib commented Oct 14, 2019

Added new version of the icon and updated the "red" color. :)

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the logo in detail it seems the middle of the "o" is not in the enter while they should be (potentially there are other things that are similarly slightly off). Perhaps you set the precision too low when optimizing the icon? Can you try to fix that @dennib?

Also, can you make sure the SVG starts at the first line of the file 😉

@dennib
Copy link
Contributor Author

dennib commented Oct 15, 2019

Mmmh I had, in fact, problems with the precision (the icon would result very off), but at last it seemed it was looking good (maybe I commited the wrong svg file or I missed something).

I will look into it (and eliminate the blank line) :)

@dennib
Copy link
Contributor Author

dennib commented Oct 15, 2019

It seems to be a problem with Adobe Illustrator export (not with the optimization part).
I tried to work with it, do you think it's ok now?

@ericcornelissen ericcornelissen merged commit 40c3b20 into simple-icons:develop Oct 17, 2019
@ericcornelissen
Copy link
Contributor

Thanks for the updated @dennib, looking good now 😄


It seems to be a problem with Adobe Illustrator export (not with the optimization part).

Do you know (roughly) what the issue was? Care to share it here?

@dennib
Copy link
Contributor Author

dennib commented Oct 17, 2019

Thanks for the updated @dennib, looking good now 😄

It seems to be a problem with Adobe Illustrator export (not with the optimization part).

Do you know (roughly) what the issue was? Care to share it here?

Sorry, I wasn't able to clearly identify the problem, it seemed like every different combination of svg export options (even from different Adobe Illustrator export commands) would produce the same svg with misplaced "O centers".
I had to manually move them and export the icon again and again until it seemed correct.

ericcornelissen added a commit that referenced this pull request Oct 23, 2019
# New icons

- LibreOffice (#1763)
- IBM (#1768)
- Apache Airflow (#1766)
- Cisco (#1769)
- Epson (#1770)
- HP (#1759)
- CentOS (#1764)
- Minetest (#1751)
- Genius (#1777)
- Lenovo (#1772)
- iDEAL (#1778)
- Plesk (#1781)
- Bancontact (#1779)
- Krita (#1775)
- XRP (#1783)
- Ripple (#1784)
- SVG (#1790)
- Nec (#1796)
- Nim (#1776)
- Habr (#1804)
- Symantec (#1797)
- Analogue (#1802)
- AdGuard (#1810)
- Strapi (#1787)
- GIMP (#1813)
- uBlock Origin (#1815)

# Updated icons

- Apple Podcasts (#1803 and #1805)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants