Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gimp icon (simple-icons#1709) #1813

Merged
merged 3 commits into from Oct 23, 2019
Merged

Gimp icon (simple-icons#1709) #1813

merged 3 commits into from Oct 23, 2019

Conversation

reginareynolds
Copy link
Contributor

Issue: #1709

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

While GIMP has an official logo, it does not seem to have an official color. I found an email thread from several years ago discussing the possibility of creating a design document, but as of now, it doesn't seem to exist. The site also does not have a primary color theme. I used a color picker on the colorized version of the GIMP logo to choose the hex value.

The logo used for the final .svg is located in the header and footer of the page linked in the JSON information. I did not link the image directly in the event that it changes locations on their server.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Oct 22, 2019
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good @reginareynolds, excellent Pull Request 👌

Due to the ambiguity of the colour I will leave it to one of the other @simple-icons/maintainers to merge this 🙂

@birjj
Copy link
Contributor

birjj commented Oct 22, 2019

One minor detail (and the cause of the build failing): we use lowercase file names, so GIMP.svg should be gimp.svg instead. Other than that, this looks good!

@birjj
Copy link
Contributor

birjj commented Oct 23, 2019

👍 Thanks for the update and your work on this @reginareynolds! We appreciate it a lot.

@birjj birjj merged commit 2090de2 into simple-icons:develop Oct 23, 2019
@reginareynolds reginareynolds deleted the GIMP-icon branch October 23, 2019 13:32
ericcornelissen added a commit that referenced this pull request Oct 23, 2019
# New icons

- LibreOffice (#1763)
- IBM (#1768)
- Apache Airflow (#1766)
- Cisco (#1769)
- Epson (#1770)
- HP (#1759)
- CentOS (#1764)
- Minetest (#1751)
- Genius (#1777)
- Lenovo (#1772)
- iDEAL (#1778)
- Plesk (#1781)
- Bancontact (#1779)
- Krita (#1775)
- XRP (#1783)
- Ripple (#1784)
- SVG (#1790)
- Nec (#1796)
- Nim (#1776)
- Habr (#1804)
- Symantec (#1797)
- Analogue (#1802)
- AdGuard (#1810)
- Strapi (#1787)
- GIMP (#1813)
- uBlock Origin (#1815)

# Updated icons

- Apple Podcasts (#1803 and #1805)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants