Add iDEAL icon #1778
Merged
Add iDEAL icon #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
Colour and SVG look good to me, nice work 👌 Just one question @Paulsky: did you optimize the SVG using SVGO or SVGOMG?
Small tip regarding GitHub(/MarkDown): our Pull Request template looks a little like
...
- [ ] I updated the JSON data in `_data/simple-icons.json`
- [ ] I optimized the icon with SVGO or SVGOMG
- [ ] The SVG `viewbox` is `0 0 24 24`
...Then, if you fill them in like this
...
- [x] I updated the JSON data in `_data/simple-icons.json`
- [x] I optimized the icon with SVGO or SVGOMG
- [x] The SVG `viewbox` is `0 0 24 24`
...You get (e.g.) this
- I updated the JSON data in
_data/simple-icons.json
Instead of this
- [x ] I updated the JSON data in
_data/simple-icons.json
|
@ericcornelissen Sorry about that! I updated my comment. I optimized the SVG with SVGO. :) |
ericcornelissen
approved these changes
Oct 18, 2019
Okay good, just wanted to make sure 👍 Thanks for working on this, it is much appreciated!
Not a problem at all, just want to try to help you understand GitHub 🙂 |
|
Glad I could be of any help :) Thank you for approving/merging this PR and for your help/advice! |
ericcornelissen
added a commit
that referenced
this pull request
Oct 23, 2019
# New icons - LibreOffice (#1763) - IBM (#1768) - Apache Airflow (#1766) - Cisco (#1769) - Epson (#1770) - HP (#1759) - CentOS (#1764) - Minetest (#1751) - Genius (#1777) - Lenovo (#1772) - iDEAL (#1778) - Plesk (#1781) - Bancontact (#1779) - Krita (#1775) - XRP (#1783) - Ripple (#1784) - SVG (#1790) - Nec (#1796) - Nim (#1776) - Habr (#1804) - Symantec (#1797) - Analogue (#1802) - AdGuard (#1810) - Strapi (#1787) - GIMP (#1813) - uBlock Origin (#1815) # Updated icons - Apple Podcasts (#1803 and #1805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1746
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
It's the main color in the manual: https://www.ideal.nl/cms/files/Manual_iDEAL_logo.pdf
I used the SVG from this comment: iDeal Icon #1746 (comment)
No