Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Taobao #4632

Merged
merged 4 commits into from Jan 11, 2021
Merged

Added Taobao #4632

merged 4 commits into from Jan 11, 2021

Conversation

adamrusted
Copy link
Member

taobao

Issue: Closes #3297
Alexa rank: 8

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Converted PNG found at source to SVG.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 6, 2021
@fbernhart
Copy link
Contributor

How about using this PDF (page 19) as official source for a vectorized version?
https://doc.irasia.com/listco/hk/alibabagroup/annual/2020/ar2020.pdf

As you've manually converted the PNG, I assume there might be quite some differences to the PDF linked above.

@adamrusted
Copy link
Member Author

taobao

@fbernhart rebuilt from new source, which also included a new HEX.

@fbernhart
Copy link
Contributor

@adamrusted Looks good, but there is one small difference: The circle in the right glyph. Could you have a look at it?

image

@adamrusted
Copy link
Member Author

@fbernhart should be fixed, though had to use a precision of 4 to get the circle to optimize properly.

@fbernhart
Copy link
Contributor

@adamrusted Thanks 👍🏼 LGTM!

@fbernhart fbernhart merged commit cf0615b into simple-icons:develop Jan 11, 2021
@adamrusted adamrusted deleted the NewIcon/TaoBao branch January 12, 2021 10:14
ericcornelissen added a commit that referenced this pull request Jan 17, 2021
# New Icons

- Acer (#4680)
- AliExpress (#4712)
- Bank of America (#4722)
- Blazor (#4694)
- Blueprint (#4729)
- CodeceptJS (#3399)
- Codemagic (#4711)
- Cucumber (#4754)
- Deutsche Bahn (#4210)
- Devpost (#4771)
- Espressif (#4720)
- Flipkart (#4734)
- Folium (#4688)
- FutureLearn (#4773)
- Game Jolt (#4742)
- Git LFS (#4737)
- Google Optimize (#4785)
- Graylog (#4675)
- Headspace (#4765)
- Home Assistant Community Store (#4755)
- Hotjar (#4723)
- Jellyfin (#4674)
- Kali Linux (#4768)
- Less (#4693)
- Metro (#3183)
- Momenteo (#4676)
- NBA (#4739)
- New Japan Pro-Wrestling (#2791)
- OWASP (#4783)
- Pioneer DJ (#4709)
- PlayStation 5 (#4641)
- Postmates (#4781)
- Presto (#4623)
- QuickBooks (#4782)
- Rolls-Royce (#4772)
- Rotten Tomatoes (#4770)
- Selenium (#4769)
- Semantic UI React (#4743)
- Southwest Airlines (#2896)
- Taobao (#4632)
- The Irish Times (#4752)
- TP-Link (#4732)
- Unacademy (#4689)
- VOX (#2205)
- WALKMAN (#4670)
- Wikidata (#4738)
- Yale (#4721)

# Updated Icons

- Accusoft (#3751)
- Citrix (#4748)
- Ferrari (#4778)
- General Motors (#4741)
- Google Chat (#4695, #4736)
- Intel (#4751)
- Kahoot! (#4731)
- Kia (#4730)
- Microsoft (#4649)
- Visa (#4719)
- Webflow (#4715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taobao
2 participants